[silpa-discuss] Re: Bug in the Webfonts module

[Vasudev Kamath]

On Sunday 27 Jun 2010 10:12:12 am Santhosh Thottingal wrote:

> fixed.

>

> Thanks

> Santhosh

Hi

Again there is a issue in the Webfonts.py here is the traceback I found in my error log when tried to use this

[Sun Jun 27 11:06:09 2010] [error] [client 127.0.0.1] Traceback (most recent call last):

[Sun Jun 27 11:06:09 2010] [error] [client 127.0.0.1] File "/var/www/Silpa/silpa/dispatch.fcgi", line 31, in application

[Sun Jun 27 11:06:09 2010] [error] [client 127.0.0.1] return silpa.serve(environ, start_response)

[Sun Jun 27 11:06:09 2010] [error] [client 127.0.0.1] File "/var/www/Silpa/silpa/silpa.py", line 80, in serve

[Sun Jun 27 11:06:09 2010] [error] [client 127.0.0.1] return [module_instance.serve()]

[Sun Jun 27 11:06:09 2010] [error] [client 127.0.0.1] File "/var/www/Silpa/silpa/modules/webfonts/webfonts.py", line 48, in serve

[Sun Jun 27 11:06:09 2010] [error] [client 127.0.0.1] http_ref=http_ref.replace("Webfonts","")

[Sun Jun 27 11:06:09 2010] [error] [client 127.0.0.1] AttributeError: 'NoneType' object has no attribute 'replace'

If you hit the link from Silpa it works fine but when you use same link in html file it causes internal server error. This is because when you come from Silpa referer field will be as follows

localhost - - [27/Jun/2010:11:09:37 +0530] "POST /silpa/JSONRPC HTTP/1.1" 200 403 "http://vasudev.homelinux.net/silpa/Webfonts" "Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100618 Iceweasel/3.5.9 (like Firefox/3.5.9)"

but when you hit from stand alone html referer field will be "-" that is NoneType.

localhost - - [27/Jun/2010:11:10:07 +0530] "GET /silpa/Webfonts?font=Mallige-n HTTP/1.1" 500 640 "-" "Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100618 Iceweasel/3.5.9 (like Firefox/3.5.9)"

The field before the User-Agent is referer

This condition may not occur always but still we need to handle this condition

Thanks and Regards

Vasudev Kamath