[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [STUMP] [PATCH] Modified describe-key and where-is to check group ty
From: |
Shawn Betts |
Subject: |
Re: [STUMP] [PATCH] Modified describe-key and where-is to check group type specific keymaps. |
Date: |
Mon, 01 Jun 2009 13:09:08 -0700 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) |
Hi Ben,
Thanks for the patch! I've added it to the repo, though savannah is down so I
can't upload it yet.
Some notes:
(let ((cmd))
(loop for map in (top-maps)
do (setf cmd (lookup-key-sequence map keys))
until cmd)
Is probably better style if written as:
(let ((cmd (loop for map in (top-maps)
for cmd = (lookup-key-sequence map keys)
when cmd return cmd)))
I decided to use this version in the src.
(loop for map in (top-maps) append (search-kmap cmd map))
can be written as:
(mapcan (lambda (x) (search-kmap cmd x)) (top-maps))
But I don't this is really any better except possibly a little less consing, so
I left your version.
-Shawn
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [STUMP] [PATCH] Modified describe-key and where-is to check group type specific keymaps.,
Shawn Betts <=