Re: [STUMP] Re: Use git describe in *version* when building from git

[Ben Spencer]

On Tue, Nov 10, 2009 at 01:41:30AM +0100, Julian Stecklina wrote:
> I just noticed that this doesn't work with the RELOAD command, because
> the current working directory is most likely your $HOME instead of the
> stumpwm source directory. The attached patch fixes this problem, but is
> a bit ugly. Is there a more beautiful solution?

This breaks when loading stumpwm from a REPL.  I discovered this when
trying it out with CCL, but it turns out to affect SBCL too:


* (require 'stumpwm)
...
; compiling file "/home/ben/src/stumpwm/version.lisp" (written 12 NOV
2009 06:18:33 PM):
; compiling (IN-PACKAGE :STUMPWM)
; compiling (EXPORT (QUOTE #))

debugger invoked on a TYPE-ERROR in thread #<THREAD "initial thread"
RUNNING {10038F3241}>:
  The value NIL
  is not of type
    (OR (VECTOR CHARACTER) (VECTOR NIL) BASE-STRING PATHNAME
    FILE-STREAM).

Type HELP for debugger help, or (SB-EXT:QUIT) to exit from SBCL.

restarts (invokable by number or by possibly-abbreviated name):
  0: [TRY-RECOMPILING] Try recompiling version
  1: [RETRY          ] Retry performing #<ASDF:COMPILE-OP NIL
  {100329F091}> on
                       #<ASDF:CL-SOURCE-FILE "version" {1002F994B1}>.
  2: [ACCEPT         ] Continue, treating #<ASDF:COMPILE-OP NIL
  {100329F091}>
                       on #<ASDF:CL-SOURCE-FILE "version"
                       {1002F994B1}> as
                       having been successful.
  3: [ABORT          ] Exit debugger, returning to top level.

(PATHNAME-DIRECTORY NIL)[:EXTERNAL]
0] backtrace

0: (PATHNAME-DIRECTORY NIL)[:EXTERNAL]
1: (SB-INT:SIMPLE-EVAL-IN-LEXENV
    (PATHNAME-DIRECTORY *LOAD-PATHNAME*)
    #<NULL-LEXENV>)
2: (SB-INT:SIMPLE-EVAL-IN-LEXENV
    (MAKE-PATHNAME :DIRECTORY (PATHNAME-DIRECTORY *LOAD-PATHNAME*))
    #<NULL-LEXENV>)
3: (SB-INT:SIMPLE-EVAL-IN-LEXENV
    (MERGE-PATHNAMES ".git/"
                     (MAKE-PATHNAME :DIRECTORY
                                    (PATHNAME-DIRECTORY
                                    *LOAD-PATHNAME*)))
    #<NULL-LEXENV>)
4: (SB-INT:SIMPLE-EVAL-IN-LEXENV
    (PROBE-FILE
     (MERGE-PATHNAMES ".git/"
                      (MAKE-PATHNAME :DIRECTORY
                                     (PATHNAME-DIRECTORY
                                     *LOAD-PATHNAME*))))
    #<NULL-LEXENV>)
5: (SB-INT:SIMPLE-EVAL-IN-LEXENV
    (IF (PROBE-FILE
         (MERGE-PATHNAMES ".git/"
                          (MAKE-PATHNAME :DIRECTORY
                                         (PATHNAME-DIRECTORY
                                          *LOAD-PATHNAME*))))
        (STRING-TRIM '(#\Newline)
                     (RUN-SHELL-COMMAND
                      (FORMAT NIL "cd `dirname '~A'` && git describe"
                              (NAMESTRING *LOAD-PATHNAME*))
                      T))
        "0.9.6-git")
    #<NULL-LEXENV>)
6: (SB-INT:SIMPLE-EVAL-IN-LEXENV
    (CONCATENATE 'STRING
                 (IF (PROBE-FILE
                      (MERGE-PATHNAMES ".git/" (MAKE-PATHNAME
                      :DIRECTORY #)))
                     (STRING-TRIM '(#\Newline)
                                  (RUN-SHELL-COMMAND
                                   (FORMAT NIL
                                           "cd `dirname '~A'` && git
                                           describe"
                                           #)
                                   T))
                     "0.9.6-git")
                 " Compiled On "
                 (FORMAT-EXPAND *TIME-FORMAT-STRING-ALIST*
                                *TIME-FORMAT-STRING-DEFAULT*))
    #<NULL-LEXENV>)
7: (SB-IMPL::READ-MAYBE-NOTHING
    #<SB-SYS:FD-STREAM for "file /home/ben/src/stumpwm/version.lisp"
    {10031CC0D1}>
    #\#)
8: (SB-IMPL::READ-LIST
    #<SB-SYS:FD-STREAM for "file /home/ben/src/stumpwm/version.lisp"
    {10031CC0D1}>
    #<unavailable argument>)
9: (SB-IMPL::%READ-PRESERVING-WHITESPACE
    #<SB-SYS:FD-STREAM for "file /home/ben/src/stumpwm/version.lisp"
    {10031CC0D1}>
    NIL
    #<SB-SYS:FD-STREAM for "file /home/ben/src/stumpwm/version.lisp"
    {10031CC0D1}>
    T)
10: (SB-IMPL::%READ-PRESERVING-WHITESPACE
     #<SB-SYS:FD-STREAM for "file /home/ben/src/stumpwm/version.lisp"
     {10031CC0D1}>
     NIL
     #<SB-SYS:FD-STREAM for "file /home/ben/src/stumpwm/version.lisp"
     {10031CC0D1}>
     NIL)
11: (SB-C::READ-FOR-COMPILE-FILE
     #<SB-SYS:FD-STREAM for "file /home/ben/src/stumpwm/version.lisp"
     {10031CC0D1}>
     929)
12: (SB-C::SUB-SUB-COMPILE-FILE #<SB-C::SOURCE-INFO >)
13: ((LAMBDA ()))
14: (SB-C::%WITH-COMPILATION-UNIT #<CLOSURE (LAMBDA #)
{10031CA619}>)[:EXTERNAL]
15: (SB-C::SUB-COMPILE-FILE #<SB-C::SOURCE-INFO >)
16: (COMPILE-FILE #P"/home/ben/src/stumpwm/version.lisp")[:EXTERNAL]
17: ((SB-PCL::FAST-METHOD ASDF:PERFORM (ASDF:COMPILE-OP
ASDF:CL-SOURCE-FILE))
     #<unavailable argument>
     #<unavailable argument>
     #<ASDF:COMPILE-OP NIL {10033279E1}>
     #<ASDF:CL-SOURCE-FILE "version" {10032AF551}>)
18: ((LAMBDA
         (SB-PCL::.PV. SB-PCL::.NEXT-METHOD-CALL. SB-PCL::.ARG0.
          SB-PCL::.ARG1.))
     #<unavailable argument>
     #<unavailable argument>
     #<ASDF:COMPILE-OP NIL {10033279E1}>
     #<ASDF:CL-SOURCE-FILE "version" {10032AF551}>)
19: ((SB-PCL::FAST-METHOD ASDF:PERFORM ASDF:AROUND
      (ASDF:COMPILE-OP ASDF:CL-SOURCE-FILE))
     #<unavailable argument>
     #S(SB-PCL::FAST-METHOD-CALL
        :FUNCTION #<CLOSURE # {10031A2339}>
        :PV NIL
        :NEXT-METHOD-CALL NIL
        :ARG-INFO (2))
     #<ASDF:COMPILE-OP NIL {10033279E1}>
     #<ASDF:CL-SOURCE-FILE "version" {10032AF551}>)
20: ((LAMBDA ()))
21: ((FLET SB-THREAD::WITH-RECURSIVE-LOCK-THUNK))
22: ((FLET #:WITHOUT-INTERRUPTS-BODY-[CALL-WITH-RECURSIVE-LOCK]291))
23: (SB-THREAD::CALL-WITH-RECURSIVE-LOCK
     #<CLOSURE (FLET SB-THREAD::WITH-RECURSIVE-LOCK-THUNK)
     {7FFFF51A1459}>
     #S(SB-THREAD:MUTEX
        :NAME "World Lock"
        :%OWNER #<SB-THREAD:THREAD "initial thread" RUNNING
        {10038F3241}>
        :STATE 1))
24: (SB-C::%WITH-COMPILATION-UNIT #<CLOSURE (LAMBDA #)
{1002F5BE29}>)[:EXTERNAL]
25: (ASDF:OPERATE ASDF:LOAD-OP COMMON-LISP-USER::STUMPWM)[:EXTERNAL]
26: (ASDF::MODULE-PROVIDE-ASDF COMMON-LISP-USER::STUMPWM)
27: ((LAMBDA (#:G[REQUIRE]13)) ASDF::MODULE-PROVIDE-ASDF)
28: (SB-IMPL::%MAP-FOR-EFFECT-ARITY-1
     #<CLOSURE (LAMBDA #) {1002CCF769}>
     (ASDF::MODULE-PROVIDE-ASDF SB-IMPL::MODULE-PROVIDE-CONTRIB))
29: (REQUIRE COMMON-LISP-USER::STUMPWM NIL)
30: (SB-INT:SIMPLE-EVAL-IN-LEXENV
     (REQUIRE 'COMMON-LISP-USER::STUMPWM)
     #<NULL-LEXENV>)
31: (SB-EXT:INTERACTIVE-EVAL (REQUIRE
'COMMON-LISP-USER::STUMPWM))[:EXTERNAL]
32: (SB-IMPL::REPL-FUN NIL)
33: ((LAMBDA ()))
34: (SB-IMPL::%WITH-REBOUND-IO-SYNTAX #<CLOSURE (LAMBDA #)
{1002CCF069}>)
35: (SB-IMPL::TOPLEVEL-REPL NIL)
36: (SB-IMPL::TOPLEVEL-INIT)
37: ((LABELS SB-IMPL::RESTART-LISP))