[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [STUMP] [PATCH] command-mode-hook
From: |
Ben Spencer |
Subject: |
Re: [STUMP] [PATCH] command-mode-hook |
Date: |
Fri, 11 Mar 2011 07:34:18 +0000 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Thu, Mar 10, 2011 at 08:57:05PM -0800, Matt Spear wrote:
> On Thu, Mar 10, 2011 at 11:45 AM, Ben Spencer <address@hidden> wrote:
> > On reflection, maybe we should prepopulate the hooks with message
> > functions after all. If so, they should be named, exported functions,
> > eg command-mode-start-message and command-mode-end-message. This
> > would enable the user to selectively remove parts of the default hook.
> >
> > Anyone else have opinions on this approach?
>
> I took this approach and can change it if something else comes up.
I've changed the way these hooks are defined to use the function
symbols directly rather than via a lambda. The point here is to allow
the user to do:
(remove-hook *command-mode-start-hook* 'command-mode-start-message)
etc.
Otherwise looks cool, and I've pushed the patch. Nice work :)
Ben