|
From: | Florian Dold |
Subject: | Re: [Taler] docs: added more info about how date is parsed in request params |
Date: | Thu, 25 Mar 2021 16:36:20 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
Hi Sebastian,Good point. GNUNET_STRINGS_fancy_time_to_absolute accepts locale- and timezone-dependent strings. This would be okay for a user interface, but is unacceptable for an internet protocol.
We should either (a) Transmit "date" as a numeric timestamp in milliseconds(b) Parse the date string in a locale-independent manner, ideally using RFC3339.
- Florian On 3/25/21 3:46 PM, Sebastian Javier Marchano wrote:
I have added more information about how a `date` is parsed: Time threshold in human readable format (yyyy/MM/dd HH:mm:ss)here: https://docs.taler.net/core/api-merchant.html#inspecting-orders <https://docs.taler.net/core/api-merchant.html#inspecting-orders>I did not find another place where it should be changed.But looking at the source code this is parsed using GNUNET_STRINGS_fancy_time_to_absolute and this function handles a lot of options, should we point in the description to another place/document?What do you think about supporting timestamps?Current supported formats depend on the locale/timezone of the server and the client may have a different one.-- Sebastian
[Prev in Thread] | Current Thread | [Next in Thread] |