Re: [Taler] Possible bugs: Sending wallet2wallet payment behaves weirdly

[Florian Jung]

Hi,

On 12/6/22 00:44, Florian Jung via Taler wrote:

> First
>       bug: it appears that when I only have one coin (e.g. I tend to
>       withdraw exactly one 10 MANA coin for testing), then I get
>       "insufficient funds" on every attempt to send funds to another
>       wallet. No server request is made.
>       
>

I got a fix for you (attached, to be applied to wallet-core). Beware: it's untested, because I have zero experience with Typescript and Android development, but this looks like it should fix the problem:

In essence, the wallet-core library went through all coins and did the following (in that order):

• for all coins do:
• check if accumulated amount >= desired amount. if so, return success
• add the coin to the accumulated amount if needed

If the last coin in the wallet, however, is the one who makes  "accumulated >= desired", then the "check... if so, return success" is not executed a last time. The fix puts that check to the end of the for loop.

Best regards,

Florian

0001-Fix-insufficient-funds-bug-on-peer-push-transfer-wit.patch
Description: Text Data