[Tinycc-devel] RE: [C67] gen_modrm() can still be called

[TK]

Yes remove it there doesn't appear to be any path to that gen_modrm()
call.

Calls to o() should be considered case by case to determine if I missed
porting something.  Or replace them with assert()?

TK


> -----Original Message-----
> From: Peter "Firefly" Lund [mailto:address@hidden
> Sent: Thursday, March 13, 2003 2:45 PM
> To: Tom Kerekes
> Subject: [C67] gen_modrm() can still be called
> 
> you have left a call to gen_modrm() in -- that's a bug, isn't it?
> 
> [i386-gen.c#2164]:
> 
>     if (fr == VT_CONST ||
>         fr == VT_LOCAL ||
>         (v->r & VT_LVAL)) {
>         gen_modrm(r, v->r, v->sym, fc);
>     } else if (fr != r) {
>         o(0xc0 + fr + r * 8); /* mov r, fr */
>     }
> 
> The same goes for the calls to o(), right?
> 
> (and I see now that the bounds checking code still uses o() and IA-32
> opcodes so I'll just cut that out)
> 
> -Peter
> 
> "Of course, I'm not unbiased, but in my humble opinion, I've
>  gotten close to something that I can be really proud of."
>  -- Knuth on The Art of Computer Programming.