[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Tinycc-devel] Wandering through Dave Dodge's tcc patches...

From: Rob Landley
Subject: [Tinycc-devel] Wandering through Dave Dodge's tcc patches...
Date: Thu, 22 Feb 2007 16:06:55 -0500
User-agent: KMail/1.9.1

So I'm going through http://www.dododge.net/tcc/patches.html to make sure I 
have it all merged, and I'm remembering where I left off:

I applied the "function pointers within a conditional expression" fix, and 
the "typedef typedef;" fix, but on the function parameters patch, I can't 
reproduce the failure in my tree.  The patch isn't applied, but possibly it 
was already fixed somewhere else?

Your patch description suggests:
  extern void foo(int);
  void foo(int const x) { /* do something */ }

I tried lots of variants:
diff -r 60ea6ef39c6f tests/tcctest.c
--- a/tests/tcctest.c   Wed Feb 21 13:20:21 2007 -0500
+++ b/tests/tcctest.c   Thu Feb 22 14:55:40 2007 -0500
@@ -80,6 +80,7 @@ void statement_expr_test(void);
 void statement_expr_test(void);
 void asm_test(void);
 void builtin_test(void);
+void const_warn_test(void);

 int fib(int n);
 void num(int n);
@@ -526,6 +527,7 @@ int main(int argc, char **argv)
+    const_warn_test();
     return 0;

@@ -1991,10 +1993,12 @@ void builtin_test(void)
     printf("res = %d\n", __builtin_constant_p(constant_p_var));

-void const_func(const int a)
+extern void const_func(int a);
+void const_func(int const a)
+extern void other_const_func(const int a);
+void other_const_func(int a) { }

 void const_warn_test(void)

And I can't get "make test" to reproduce the failure with the current 
http://landley.net/hg/tinycc tree.

Am I doing something wrong?

"Perfection is reached, not when there is no longer anything to add, but
when there is no longer anything to take away." - Antoine de Saint-Exupery

reply via email to

[Prev in Thread] Current Thread [Next in Thread]