Re: [Tinycc-devel] [PATCH] arm: Handle __builtin_frame_address(1) correctly

[Thomas Preud'homme]

Le jeudi 6 décembre 2012 04:50:55, vous avez écrit :
> > 
> > Hi Kirill,
> > 
> > did you make any progress on the issue since Daniel's comments? Could you
> > let me know when you push a patch so that I can test it and bump master
> > to equal the mob branch?
> 
> Hi Thomas,
> 
> Unfortunately not that much. I was trying to investigate
> bounds-checking failures for `tcc -b -run tcc ...` tests first and it looks
> I'm close to understand what is going on (old bcheck code is not adapted
> to /proc/sys/kernel/randomize_va_space = 2). The plan was to go to arm
> issues then, but I'm going very slow, because for tcc I have only 15-20
> minutes per day and it is all in underground. Sorry. Could this issue
> please wait me for some time? (probably week or so...)

That's a worthwhile bug to fix. The ARM issue can wait, sure. We can also 
disable the test for ARM as this code never worked for ARM and it's thus not a 
regression.

> 
> As to testing the patch, you don't need me to push it to try - just pass
> the mail with the patch to `git am --scissors` and apply it locally and
> play with it.

Oh nice I didn't know about the --scissors switch. I already applied it by 
removing the text before the patch manually. Stupid me. I just felt I like the 
expertise to review the patch and after remarks from Daniel I thought I'd wait 
for a version 2 before testing. I'll test whenever I have time but I seriously 
lack of time now.

> 
> > Grischka, what do you think of releasing a rc1 after that? We got plenty
> > of features merged since last release and 3 years start to be quite a
> > long time. I know there is still many things to improve, including some
> > I care about, but it might attract new contributions or new users to
> > have a more recent release.
> 
> Grischka, if my currently-guilty-for-regressions voice counts, I'd like
> to once again ask for release too.

Despite the title of my mail, I don't count this issue as a regression. You 
just uncovered a bug by added a test. The code was already not working before.

> 
> 
> Thanks,
> Kirill

Regards,

Thomas