tinycc-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] Request code review


From: jiang
Subject: Re: [Tinycc-devel] Request code review
Date: Tue, 03 Jun 2014 20:38:46 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

Thank you for reviewing my patch.
I've followed your request to delete the assert (). Added ST_FUNC, and rearrange my commit.
Excuse me, please review my patch again, if there are other problems
https://gitcafe.com/weixiao/tinycc

I have some questions to you, explain:
1. VT_TMP. To modify tccgen.c to use later, but not now. If you commit too much, tcc in other machines out significant problem, the problem is not locked, so no problem when you have the test again after I added. (My machine is ubuntu 64) 2. Assert (). I think get_reg () and type_size () exists bug. If r == -1 and type_size return int size larger than the case (in particular s-> c is of type long), the result you want it? (May never happen to the case)

Your comments and suggestions are the driving force of my contribution

jiang




reply via email to

[Prev in Thread] Current Thread [Next in Thread]