tinycc-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] Introduce C2X _Static_assert syntax


From: Christian Jullien
Subject: Re: [Tinycc-devel] Introduce C2X _Static_assert syntax
Date: Mon, 9 Mar 2020 07:18:39 +0100

Matthias, this unfortunately the "right" process :((

Nothing is broken on Windows 32/64, Linux arm/aarch64 and Linux x86_64.

Thanks for your contribution.

-----Original Message-----
From: Tinycc-devel [mailto:tinycc-devel-bounces+eligis=address@hidden] On 
Behalf Of uso ewin
Sent: Sunday, March 08, 2020 23:53
To: address@hidden
Subject: Re: [Tinycc-devel] Introduce C2X _Static_assert syntax

I got no answer so I've push

I hope I didn't break anything

Matthias,

On Thu, Mar 5, 2020 at 10:01 AM uso ewin <address@hidden> wrote:
>
> On Tue, Mar 3, 2020 at 7:47 PM Michael Matz <address@hidden> wrote:
> >
> > Hello,
> >
> > On Sat, 29 Feb 2020, uso ewin wrote:
> >
> > > Hello, as I was working on fixing _Static_assert bug,
> > > I've saw that it was fairly easy to add C2x _Static_assert
> > > syntax support to tinycc.
> > >
> > > the code is here: 
> > > https://github.com/cosmo-ray/tcc/commits/static_assert_c2x
> > >
> > > The only difference with current _Static_assert is
> > > that we can omit the literal string.
> > >
> > > Is the code okay ?
> > >
> > > Are you ok to introduce C2x feature to tinycc ? (gcc allow this too)
> >
> > Fine with me at least.  I'd say also without testing for anything like
> > -std=c2x, your call.
> >
> Ok, then I wont add -std=c2x now, mainly because gcc seems to accept c2x
> _Static_assert syntax even without the argument, (like it does for _Generic)
> I could add -std=c2x that only add the define, but if that's all this do,
> maybe wait for features that require it ?
>
> > I have a mild preference for using parse_mult_str no matter if the
> > condition is true or false, obviating the need for an extra loop to skip
> > the STR tokens.  Remember that you need to cstr_free the string in that
> > case (which you can avoid right now only because tcc_error doesn't
> > return).
> >
> Thanks for the feedback, I've update my branch (force push)
> following your recommendations.
> >
> > Ciao,
> > Michael.
> >
>
> I'll wait 3,4 days to see if there is feedback, if no I'll push on mob
>
> Matthias,

_______________________________________________
Tinycc-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/tinycc-devel




reply via email to

[Prev in Thread] Current Thread [Next in Thread]