Re: [Tinycc-devel] 124_atomic_counter.c is broken on arm and arm64

[Christian Jullien]

Fixed in mod as privately suggested by Urs Janßen.

-----Original Message-----
From: Tinycc-devel [mailto:tinycc-devel-bounces+eligis=orange.fr@nongnu.org] On 
Behalf Of Christian Jullien
Sent: Friday, April 09, 2021 11:19
To: tinycc-devel@nongnu.org
Subject: Re: [Tinycc-devel] 124_atomic_counter.c is broken on arm and arm64

Hi Grischka, at least on RPi your commit gives:

./configure --cc=gcc --prefix=/usr/local
Binary directory    /usr/local/bin
TinyCC directory    /usr/local/lib/tcc
Library directory   /usr/local/lib
Include directory   /usr/local/include
Manual directory    /usr/local/share/man
Info directory      /usr/local/share/info
Doc directory       /usr/local/share/doc
Source path         /home/jullien/tinycc
C compiler          gcc (8.3)
Target OS           Linux
CPU                 arm
Triplet             arm-linux-gnueabihf
Config              arm_eabihf arm_vfp arm_vfp
Creating config.mak and config.h
gcc -o tcc.o -c tcc.c -DCONFIG_TRIPLET="\"arm-linux-gnueabihf\"" 
-DTCC_CPU_VERSION=7 -DTCC_TARGET_ARM -DTCC_ARM_EABI -DTCC_ARM_HARDFLOAT 
-DTCC_ARM_VFP        -DONE_SOURCE=0 += -DTCC_GIT_HASH="\"48df89e\"" -Wall -O2 
-Wdeclaration-after-statement -fno-strict-aliasing -Wno-pointer-sign 
-Wno-sign-compare -Wno-unused-result -Wno-format-truncation -I.
gcc: error: +=: No such file or directory
make: *** [Makefile:246: tcc.o] Error 1

-----Original Message-----
From: Tinycc-devel [mailto:tinycc-devel-bounces+eligis=orange.fr@nongnu.org] On 
Behalf Of grischka
Sent: Friday, April 09, 2021 11:13
To: tinycc-devel@nongnu.org
Subject: Re: [Tinycc-devel] 124_atomic_counter.c is broken on arm and arm64

Dmitry Selyutin wrote:
> Hi Christian,
>
> I've been under impression that this should be skipped until
> per-platform support is implemented. The Makefile marks it as skipped;
> isn't it skipped when running the whole test suite?

Because you were using ifneq.  Anyway, I fixed it.  Also, windows
doesn't know pthreads.

And well, this is tinycc.  We do not need 6 new files to add just
120 lines of C to the library.

> P.S. Is it possible to build cross-compile tcc for ARM on x86, and check
> all tests? Could you help me, please?

No, cross-compiled code cannot be run on the platform where it
was compiled, in general.  In many cases it cannot even be fully
built, when it relies on include headers or libraries of a
different system.  See also my note on lib/stdatomic.c, for
the same reason:

   // for libtcc1, avoid including files that are not part of tcc
   // #include <stdint.h>

--- grischka

_______________________________________________
Tinycc-devel mailing list
Tinycc-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/tinycc-devel


_______________________________________________
Tinycc-devel mailing list
Tinycc-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/tinycc-devel