Re: [wdiff-bugs] no suitable temporary directory

[Denver Gingerich]

On Tue, Jan 26, 2010 at 5:35 PM, Karl Berry <address@hidden> wrote:
> Hi Martin and all,
>
> With wdiff 0.5.94, if I set the TMPDIR envvar to /dev/shm, I get:
> wdiff: no suitable temporary directory exists
>
> (A more specific error message would be nice, about what directory/ies
> were tried and what the actual problem is.)
>
> With TMPDIR set to /tmp (for example) or unset completely, it works fine.
>
> The permissions are:
>
> drwxrwxrwt   7 root root  180 Jan 26 10:14 /dev/shm
> drwxrwxrwt. 22 root root 4096 Jan 26 10:11 /tmp
>
> Perhaps it's because /tmp has the selinux context
> system_u:object_r:tmp_t:s0 (the "." above), but I have selinux disabled,
> so I don't see why it should matter.  And sort from current coreutils
> (8.4) (for example) does not complain with TMPDIR=/dev/shm, which I
> expect it would if it was a generic problem.
>
> Wdyt?

Since it might be relevant, I've attached a (relatively) recent fix I
made in response to some security concerns.  It's revision 1.6 of
src/wdiff.c in CVS, which doesn't seem to be mirrored via cvsweb
(anymore?).

The patch was made in response to the following:
http://lists.gnu.org/archive/html/wdiff-bugs/2007-07/msg00005.html
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=425254

Anyway, I hope this helps.  I don't see any particularly problematic
sections, but someone more well-versed in file permissions might see
something in the diff.

Denver
http://ossguy.com/

wdiff-mkstemp.diff
Description: Text Data