emms-help
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [emms-help] mpv player alternative with json-ipc


From: Mike Kazantsev
Subject: Re: [emms-help] mpv player alternative with json-ipc
Date: Mon, 28 May 2018 17:44:10 +0500

On Sat, 26 May 2018 03:36:34 +0500
Mike Kazantsev <address@hidden> wrote:

> On Fri, 25 May 2018 18:25:13 -0400
> Yoni Rabkin <address@hidden> wrote:
> 
> > At least I'm not asking you to modify your idiosyncratic
> > indentation. Now _that's_ a red line I wouldn't ask anyone to cross.  
> 
> It's some kind of auto-indenter that does that weird tabs-and-spaces
> thing which I never looked into, no?
> 
> In which case fix there should be pretty straightforward - run that
> formatter before commit and not bother with indentation.

Found that lispy-multiline formatter seem to produce good aligned
sexp formatting, which seem to be much more in-line with the existing
code, so used that.

Some existing emms code seem to have a mix of tabs and spaces, which I
don't think is consistent (main emms.el can be good example),  and
probably simply due to indent automation, where emacs auto-inserts tab
instead of 4 or 8 spaces (depending on tab-size) sometimes.

Used strictly spaces with lispy-multiline formatter for consistency,
but shouldn't be a problem to tweak that to use tabs + spaces mix as
well, if preferrable.

Please let me know if it's gotten better or worse this way.

My indentation practices are indeed a bit unorthodox, so I think it'd
make sense to ditch these in any collaborative project, especially as it
doesn't really take much effort with great tools like lispy fixing it
all for you.


-- 
Mike Kazantsev // fraggod.net



reply via email to

[Prev in Thread] Current Thread [Next in Thread]