Re: [fluid-dev] Again on "Compile time constant lookup tables"

[Ceresa Jean-Jacques]

Hi Carlo,

 

First thanks for this usefull work.

I think that the reason of using of python script instead of a C program is not obvious for a lot of people, particularly for those who doesn't use cross compiler tools chain very often.

Please, may i suggest you add some comments about these reasons in a readme file (or  in gen_rvoice_dsp.py and gen_conv.py ).

Regards.

jjc

 

 

 

 

> > Message du 28/09/18 10:40
> > De : "Carlo Bramini" <address@hidden>
> > A : "FluidSynth mailing list" <address@hidden>
> > Copie à : 
> > Objet : Re: [fluid-dev] Again on "Compile time constant lookup tables"
> > 
> > Hello everyone, if somebody is interested, I did a PR with Python support some days ago. It has resolved all issues on my side, it worked on embedded ARM, on MSVC versions 6 and 2017, on mingw-w64 and on unix-like cygwin. Although I understand that it cannot be accepted, perhaps it may be useful to other people. Sincerely, > Il 21 settembre 2018 alle 16.51 "sqweek E." <address@hidden> ha scritto: > > On 21 Sep 2018, at 02:08, Tom M. <address@hidden> wrote: > > > > Carlo: I have no code duplication here because the C implementation for calculating the tables is gone. > > > > Removing the C implementation means that python would become a required build dependency, which is what I want to avoid, because, again, there is no reason to do so. > > Committing the generated code would nicely solve this. It’s a pretty clean way to prevent a build time dependency for users who don’t want to fiddle with the code imo. > > -sqweek > > _______________________________________________ > fluid-dev mailing list > address@hidden > https://lists.nongnu.org/mailman/listinfo/fluid-dev _______________________________________________ fluid-dev mailing list address@hidden https://lists.nongnu.org/mailman/listinfo/fluid-dev