[Help-smalltalk] gst-package "empty filenames are invalid"

[Tony Garnock-Jones]

From a fresh git checkout, on OS X 10.5.4,

 - make works
 - make install gets part-way through before failing.

It looks like there's some code duplication in Directory class >> 
append:to: and FilePath class >> append:to:. The FilePath version is 
newer, but behaves differently in the case of an empty fileName 
parameter. Should the redundancy be removed? Should they be made to 
behave the same? Am I looking in completely the wrong place?

Here's how it fails:

...
ln -f /opt/gst-HEAD/bin/gst-load /opt/gst-HEAD/bin/gst-doc
ln -f /opt/gst-HEAD/bin/gst-load /opt/gst-HEAD/bin/gst-remote
test -z "/opt/gst-HEAD/share/aclocal" || build-aux/install-sh -c -d 
"/opt/gst-HEAD/share/aclocal"
 /usr/bin/install -c -m 644 'build-aux/gst.m4' 
'/opt/gst-HEAD/share/aclocal/gst.m4'
 /usr/bin/install -c -m 644 'build-aux/gst-package.m4' 
'/opt/gst-HEAD/share/aclocal/gst-package.m4'
 /usr/bin/install -c -m 644 'smalltalk-mode.el' 
'/opt/gst-HEAD/share/emacs/site-lisp/smalltalk-mode.el'
 /usr/bin/install -c -m 644 'smalltalk-mode.elc' 
'/opt/gst-HEAD/share/emacs/site-lisp/smalltalk-mode.elc'
 /usr/bin/install -c -m 644 'gst-mode.el' 
'/opt/gst-HEAD/share/emacs/site-lisp/gst-mode.el'
 /usr/bin/install -c -m 644 'gst-mode.elc' 
'/opt/gst-HEAD/share/emacs/site-lisp/gst-mode.elc'
test -z "/opt/gst-HEAD/lib/pkgconfig" || build-aux/install-sh -c -d 
"/opt/gst-HEAD/lib/pkgconfig"
 /usr/bin/install -c -m 644 'gnu-smalltalk.pc' 
'/opt/gst-HEAD/lib/pkgconfig/gnu-smalltalk.pc'
make  install-data-hook
./gst-tool gst-package 
--kernel-dir="/Users/tonyg/src/gnu-smalltalk/kernel" 
--image="/Users/tonyg/src/gnu-smalltalk/gst.im" --dist --copy --all-files \
          --destdir="" --target-dir="/opt/gst-HEAD/share/smalltalk" \
          --srcdir="." ./packages.xml
gst-package: Invalid argument : empty filenames are invalid
make[3]: *** [install-data-hook] Error 1
make[2]: *** [install-data-am] Error 2
make[1]: *** [install-am] Error 2
make: *** [install-recursive] Error 1