lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new


From: Masamichi Hosoda
Subject: Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?'
Date: Fri, 25 Jan 2019 23:58:52 +0900 (JST)

>>> Is dir guaranteed to be a relative path?
>>
>> It seems that there is no guarantee.
>> But, `make check` invokes `output-distance` with relative paths.
>> http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=blob;f=GNUmakefile.in;h=da1f6f64e088756e07d20f8e1603ccc3a102053e;hb=HEAD#l340
>>
>> Therefore, `dir` is also a relative path.
>> There seems to be no place invoking `output-distance` other than that.
> 
> Python has os.path.join that should allow to combine cur_dir with either
> relative or absolute paths.

Thank you for your advice.
But, Werner's Issue 5466 uses `abs_dir` by `os.path.abspath ()`.
So I've uploaded Patch Set 2 using `abs_dir`.
It requires Issue 5466.

https://sourceforge.net/p/testlilyissues/issues/5467/
https://codereview.appspot.com/349110043



reply via email to

[Prev in Thread] Current Thread [Next in Thread]