[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] Using binary database for 0.26?
From: |
Timothy Brownawell |
Subject: |
Re: [Monotone-devel] Using binary database for 0.26? |
Date: |
Mon, 16 Jan 2006 19:06:33 -0600 |
On Mon, 2006-01-16 at 10:12 +0100, Christof Petig wrote:
> Hi Nathaniel,
>
> I waited the weekend for you to comment on my recently finished
> sqlite3.binary port to 0.26.
>
> How do you feel about using it in mainline? It is ready AFAICT.
> - not for 0.26 we already changed enough?
> - directly after 0.26 is released?
> - the user has to migrate anyway, lets use it
> - after I took a more close look ...
>
> Christof
[schema_migration.cc]
+// we could as well use the fact that uuencoded gzip starts with H4sI
+// but we can not change comments on fields
This comment seems kind of opaque.
Why does it need the "WHERE delta like 'H4sI%'" and
"WHERE length(keydata)>160" conditions on all the UPDATEs?
(In particular the length ones. Even if monotone doesn't normally
generate keys that big, does it require that they're not? Could someone
have modified it to generate longer keys (so the not-base64 version
would still be longer than 160), and would that be interoperable?)
tests/t_migrate_schema.at hasn't been updated.
Tim