Re: [Monotone-devel] cygwin buildbot [Was: 0.27 cygwin compile error]

[Lapo Luchini]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Lapo Luchini wrote:
> Yes, indeed seems that sqlite's os.h treats Cygwin as a "WIN" build
> instead of a "UNIX" one.
Just removing the "__CYGWIN__" case from sqlite/os.h seemed to resolve
the problem.
But the are locking issues indeed.

filemon's output:
11.11.43    mtn.exe:3928    QUERY SECURITY 
C:\cygwin\home\build\mtbuildbot\slave-dir\cygwin_x86_distcheck\monotone.db 

SUCCESS     
11.11.43    mtn.exe:3928    LOCK 
C:\cygwin\home\build\mtbuildbot\slave-dir\cygwin_x86_distcheck\monotone.db 

SUCCESS    Excl: Yes Offset: 1073741825 Length: 1 
11.11.43    mtn.exe:3928    LOCK 
C:\cygwin\home\build\mtbuildbot\slave-dir\cygwin_x86_distcheck\monotone.db 

SUCCESS    Excl: Yes Offset: 1073741824 Length: 1 
11.11.43    mtn.exe:3928    LOCK 
C:\cygwin\home\build\mtbuildbot\slave-dir\cygwin_x86_distcheck\monotone.db 

NOT GRANTED    Excl: Yes Offset: 1073741826 Length: 510 
11.11.43    mtn.exe:3928    LOCK 
C:\cygwin\home\build\mtbuildbot\slave-dir\cygwin_x86_distcheck\monotone.db 

SUCCESS    Excl: No Offset: 1073741826 Length: 510 
11.11.43    mtn.exe:3928    UNLOCK 
C:\cygwin\home\build\mtbuildbot\slave-dir\cygwin_x86_distcheck\monotone.db 

RANGE NOT LOCKED    Offset: 1073741824 Length: 2 
11.11.43    mtn.exe:3928    UNLOCK 
C:\cygwin\home\build\mtbuildbot\slave-dir\cygwin_x86_distcheck\monotone.db 

RANGE NOT LOCKED    Offset: 0 Length: -1 

I know little of Windows internals... I guess it has something to do
with cygwin's implementation of fcntl? Uhm.

So, I "rever os.h" and changed os_win.h instead:

============================================================
- --- sqlite/os_win.c     c6976ae50b61fb5b7dce399e578aa1865f02b84f
+++ sqlite/os_win.c     d22722b5317b168bf62e8905ae6000db406a1a94
@@ -777,7 +777,7 @@
 ** name of a directory, then that directory will be used to store
 ** temporary files.
 */
- -char *sqlite3_temp_directory = 0;
+char *sqlite3_temp_directory = "C:\\cygwin\\tmp\\";
 
 /*
 ** Create a temporary file name in zBuf.  zBuf must be big enough to

This way sqlite cerates his lock files in C:\cygwin\tmp (aka /tmp) to
which the build bot has access.
It is not a patch as clean as I'd like, though. And I really think
SQLite should use UNIX-mode under Cygwin.
But oh well. At least as a "mtn.exe" for my specific build bot it can
certainly do.

And indeed it seems to work, finally!

> tail http://venge.net:9000/cygwin_x86_distcheck/builds/13/monotone/0

mtn: finding items to synchronize:
mtn: ticks: >="bytes in"/1024, <="bytes out"/1024, c="certs in"/3,
r="revs in"/1
mtn:
><cr>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
mtn:
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
mtn:
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>


YAY! Let's hope it continues correctly.

- --
Lapo Luchini
address@hidden (OpenPGP & X.509)
www.lapo.it (Jabber, ICQ, MSN)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQIcBAEBAgAGBQJEuLgsAAoJELBiMTth2oCDshsP/jnhZPTmFwNG3/hdTnGMuE/C
yUvzsUfklHc2yJfV3+mEH9J/ue8XTXLvawlSDExFJx0OTzNnH3Wk06HMGO1tx/xq
nTS07KNNfPsaYTtarY54fR0lzpDRTINpAmqBGVZj1aHoH1AcDvu42LXOLgjdxCPz
uxhJtesM2Ok0kxWP2FF0/wlmZq7G5b2QI6Fsn2OfZ7gYpi6V3n/5iccqGI+oaZKZ
IgZCJwN4TNRUoVBfqnz2A19CZ7KuoY8ZlwybUohgF6BrXmricFKXyuRqRJyblNDz
o7JlTR4x0bq3pqVH0ZuaUNnMT/RCuFVZJmQyboz5wtAYzU2FlbOERM3ZUMkCaaAu
qz2RqPKb+8+Vyt2X1w4oEa21MVhbWWDoz67JCeB8V/oH6D9gJyoFxlWUocs3RqOr
CmRNuiLZllL7WwWMzUNf3Mp1ZIsHztyy/FqhuG80nKB2yX+YzgQvNyp43pGe3VRz
1XxFNEfIL8duwp5S4YaLsPEPqmTiit7lsFnO6OJAIjjvqXA/Ld6IHlV+xghPsAFx
BH1m1jzDA/tuc+ztBne5iBRCI5G+LIBP2i/rlmEwYlwfW1I9o31IVRDIRDUB0DuT
4t+pcSfIkLQYn9+zeChaNLhwUAENFFqyJtAT22poAseD9pGpx5DBbW/g0/qV0X3U
EbCQBzv/TvSzqEBjHf9Y
=U3/l
-----END PGP SIGNATURE-----