Re: [Monotone-devel] Re: netsync connection info cleanup

[Timothy Brownawell]

On 04/28/2010 06:06 AM, Thomas Keller wrote:
> Am 28.04.2010 12:36, schrieb Thomas Moschny:
> > Am Sun, 18 Apr 2010 20:49:37 +0200
> > schrieb Thomas Keller<address@hidden>:
> >
> > > Secondly, I'd actively deprecate any branch name which does not match
> > > the following regular expression, i.e. by throwing a warning when a
> > > branch cert which a different value is created:
> > >
> > >     ^([\w\d]+([-][\w\d]+)*)(\.[\w\d]+([-][\w\d]+)*)*$
> >
> > Sounds good to me, but maybe we have to ask our users, whether that'd
> > be ok for them. And we should still allow them to use other branch names
> > if they wish so (because technically, there's no need for such a
> > restriction).
>
> Depending on the actual URI scheme we'll be using, we can further adapt
> the regular expression above, like f.e. if the URI scheme will look like
> this:
>
>         scheme://address@hidden/db?include,-exclude,include

This is in the nvm.connection_info_cleanup branch now. Are there any 
objections to merging it? It doesn't include any string changes.

> this should be sufficient I think (untested):
>
>         ^[^-,*][^,*]+$

I think we also don't like '+' and '%' due to urlencoding. Any 
objections to requiring an --allow-discouraged-branch-names option to 
create branch certs that don't match /^[^-,*+%][^,*+%]*$/?

I guess this would have to be after this upcoming release, due to the 
new translatable strings it would have.

> > "mtn ls branches | grep -v -E '^(\w+(-\w+)*)(\.\w+(-\w+)*)*$'" shows only
> > one branch that doesn't match in my local copy of the monotone db
> > (prjek.net:tester).
>
> Wouldn't be a problem with the above naming.
>
> Thomas.

--
Timothy

Free public monotone hosting: http://mtn-host.prjek.net