Re: [Monotone-devel] nvm.options

[Timothy Brownawell]

On 07/21/2010 06:15 PM, Thomas Keller wrote:
> Am 21.07.10 01:10, schrieb Thomas Keller:
> > If the compilation issue is fixed, I'll check the UI again and may come
> > up with other little things :)
>
> Some more observations:
>
> - --verbosity changes the level between -2 and 1 (default is 0) - but I
>    actually can't see a difference between 0 and 1. The option text for
>    --verbose says "verbose completion output", but there is no
>    difference between
>
>      $ mtn ls certs h:net.venge.monotone  (verbosity 0)
>
>    and
>
>      $ mtn --verbose ls certs h:net.venge.monotone  (verbosity 1)
>
>    i.e. both output
>
>      mtn: expanding selection 'h:net.venge.monotone'
>      mtn: expanded to 'c36b63fe53580cdf51cd5c6afa42fc4a30a1d095'

It only affects 'complete', 'db info', and 'version' (the commands that 
take --full).

Also I think it really doesn't need to be mixed up with the (other) 
verbosity options; it controls the amount of expected output, while they 
control error/warning/debug messages. So I dropped --version and 
un-deprecated --full, and separated it from the others.

>    On a slightly related note - the option --verbose has -v as short
>    option in many other programs I know, but --verbose and -v do
>    have completly different meanings here - is that something we want?
> - If I increase the verbosity to 2 or set --verbosity=2, the --debug
>    output is shown (which is reasonable, but not yet documented in the
>    option text)
> - I dislike the alphabetic ordering of our global options, because they
>    spread all the verbosity-related cruft - and we have six (!) options
>    for that purpose now:
>
>      -v to increase
>      --debug to set 2
>      --verbose to set 1
>      --quiet | -q to set -1
>      --reallyquiet to set -2
>      --verbosity to set to a number between -2 and 2

This really is a bit too many. I've dropped -v (and --verbose as above), 
and deprecated --reallyquiet in favor of --verbosity=-2. That leaves us 
with just 3 in this set (--verbosity=n, --quiet, and --debug). I think 
--quiet and --debug should probably stay, since they're somewhat standard.

>    Likewise, there are other sets of related options which would look
>    great grouped together:
>
>      --key | -k / --use-default-key
>      --keydir
>
>      --confdir
>      --no-default-confdir / --allow-default-confdir
>
>      --rcfile / --clear-rcfiles
>      --norc / --yesrc
>      --nostd / --stdhooks
>
>      --dump
>      --log
>      (these two could get grouped into the verbosity-related group)
>
>    Is it possible to group global options further, add an empty line
>    between each group and sort the members of a group alphabetically?

Should be doable, not sure how easy it would be. Probably this would 
mean overloading the meaning of OPTSET/OPTSET_REL a bit, to control 
formatting as well as the internal convenience and resettability 
functions they have now.

> - Personally I like it a bit better if the long options are broken into
>    the next line a little earlier, i.e. not before they've taken up
>    50% of the available space, but already if they've taken up 33%. The
>    change is simple to do (ui.cc, desired_namewidth divided by 3, not
>    two), so any objections against that?

That's changed.

> - All tests pass on OSX 10.5

:)

--
Timothy

Free public monotone hosting: http://mtn-host.prjek.net