monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] nvm.alt_tmpdir


From: Stephen Leake
Subject: Re: [Monotone-devel] nvm.alt_tmpdir
Date: Mon, 16 May 2011 17:59:26 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (windows-nt)

Stephen Leake <address@hidden> writes:

> Nathaniel Smith <address@hidden> writes:
>
>> On Mon, May 16, 2011 at 1:23 PM, Stephen Leake
>> <address@hidden> wrote:
>>>    Note that 'mv' between two drives succeeds on Windows
>>
>> Wouldn't it be easier to just enhance the POSIX move-this-file
>> function so that it checks if they're on the same filesystem (you can
>> get this from stat(2)), and then either calls rename(2) or does a
>> copy+unlink?
>
> Hmm.
>
> Yes, that would be easier. 

The issue of how to write a test for it is still relevant.

But it's far less code, so testing only in actual use would not be too bad.

-- 
-- Stephe



reply via email to

[Prev in Thread] Current Thread [Next in Thread]