Re: wmf saver for sketch

[Bernhard Herzog]

Lukasz Pankowski <address@hidden> writes:

> Sorry to bother you once more (first on sketch list), but I expected
> any answer -- at least ,,It is a totally unusable trash'' :-).

I'm sorry that I didn't reply. I was very busy with other stuff and
sometimes I don't get around to answer emails I as fast as I would like
to (and sometime, sadly I never get around to it :( ).

However, I tested it briefly when you announced it the first time. It
worked well on the simple drawings I tested it with. I'll include it in
Sketch in the next release, if you don't mind :)

One thing I'm gong to change, though, is an inconsistency in the license
statement. At beginning it says that it's LGPL but later says that there
should be a copy of the GPL accomanying the source. This is also in the
cgm filters, so you probably simply inherited this. I'll correct this to
refer to the LGPL.

Some other points:

There are lines longer than 79 characters in the source. Would be nice
if this could get fixed. There are also some lines that use tabs for
indents, but I'll fix those myself.

It would also be nice if there were some test cases for Sketch 0.7's
test suite. The tests for saving sk files and svg files could serve as
examples even though they currently only have tests I wrote when I fixed
bugs in the export filters.

The points about source code formatting and more importantly the test
cases apply to all new code and code changes and not only to the wmf
export filter, of course.

   Bernhard

-- 
Intevation GmbH                                 http://intevation.de/
Sketch                                 http://sketch.sourceforge.net/
MapIt!                                           http://www.mapit.de/