[aspell-devel] Possible bug in new_filer.cpp

[Peter Kümmel]

While compiling aspell I get warnings in new_filter.cpp.

Is the assignment in the if() really by design or is it
a typo and copy&paste error?

When it should really be an assignment, why not move it
into the code block?
Just an idea.

Peter


Index: lib/new_filter.cpp
===================================================================
RCS file: /sources/aspell/aspell/lib/new_filter.cpp,v
retrieving revision 1.33
diff -u -B -b -r1.33 new_filter.cpp
--- lib/new_filter.cpp  21 Oct 2005 12:16:03 -0000      1.33
+++ lib/new_filter.cpp  11 Jun 2006 10:47:06 -0000
@@ -178,7 +178,7 @@
       if (!f)
         return make_err(no_such_filter, filter_name);
 #endif
-      if (use_decoder && f->decoder && (ifilter = f->decoder())) {
+      if (use_decoder && f->decoder && (ifilter == f->decoder())) {
         RET_ON_ERR_SET(ifilter->setup(config), bool, keep);
         ifilter->handle = decoder_handle.release();
        if (!keep) {
@@ -187,7 +187,7 @@
           filter.add_filter(ifilter.release());
         }
       }
-      if (use_filter && f->filter && (ifilter = f->filter())) {
+      if (use_filter && f->filter && (ifilter == f->filter())) {
         RET_ON_ERR_SET(ifilter->setup(config), bool, keep);
         ifilter->handle = filter_handle.release();
         if (!keep) {
@@ -196,7 +196,7 @@
           filter.add_filter(ifilter.release());
         }
       }
-      if (use_encoder && f->encoder && (ifilter = f->encoder())) {
+      if (use_encoder && f->encoder && (ifilter == f->encoder())) {
         RET_ON_ERR_SET(ifilter->setup(config), bool, keep);
         ifilter->handle = encoder_handle.release();
         if (!keep) {