Re: [aspell-devel] patch to fix for g++ -O3

[Jose Da Silva]

On Friday 05 January 2007 18:18, you wrote:
> I'm not convinced that your Makefile.in was regenerated.  My libtool
> compile commands look like the following (after patch and regeneration):
>
> if g++ -DHAVE_CONFIG_H -I. -I../aspell-0.60.5 -I./gen  -Igen
>
> Note the very last flag "-Igen".  Part of my patch added "-Igen" in the
> AM_CPPFLAGS in Makefile.am (the *builddir's* gen/ dir), which doesn't show
> up in any of your compile commands in the log excerpt.

Trying it again:
tar -xzf ../aspell-0.60.5.tar.gz
cd aspell-0.60.5/
patch -p1 < ../aspell-0.60.5.patch
autoreconf
mkdir build
cd build
../configure CFLAGS="-g -O3" CXXFLAGS="-g -O3" -C

One line had a warning:
configure: WARNING: Aspell will not be able to Display UTF-8 characters 
correctly.

Several output lines had g++ but there was no output containing:
if g++ -DHAVE_CONFIG_H -I. -I../aspell-0.60.5 -I./gen  -Igen

> Can you compare the timestamps of Makefile.am and Makefile.in?

make
(make failed, therefore no "make check" done), here's the last lines:
------------------
 
g++ -DHAVE_CONFIG_H -I. -I.. -I./gen -Igen -I../common -I../interfaces/cc/ 
-I../modules/speller/default/ -DLOCALEDIR=/usr/local/share/locale -g -O3 
-fno-exceptions -MT 
common/string_list.lo -MD -MP -MF 
common/.deps/string_list.Tpo -c ../common/string_list.cpp  -fPIC -DPIC -o 
common/.libs/string_list.o
cd gen; 
perl ../../gen/mk-dirs_h.pl /usr/local /usr/local/lib/aspell-0.60 
/usr/local/lib/aspell-0.60  /usr/local/etc 
>  dirs.h
depbase=`echo common/config.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`; \
        if /bin/sh ./libtool --tag=CXX --mode=compile 
g++ -DHAVE_CONFIG_H -I. -I.. -I./gen  -Igen -I../common -I../interfaces/cc/ 
-I../modules/speller/default/ -DLOCALEDIR="/usr/local/share/locale"   -g -O3 
-fno-exceptions -MT 
common/config.lo -MD -MP -MF "$depbase.Tpo" -c -o common/config.lo 
common/config.cpp; \
        then mv -f "$depbase.Tpo" "$depbase.Plo"; else rm -f "$depbase.Tpo"; 
exit 1; fi
 
g++ -DHAVE_CONFIG_H -I. -I.. -I./gen -Igen -I../common -I../interfaces/cc/ 
-I../modules/speller/default/ -DLOCALEDIR=/usr/local/share/locale -g -O3 
-fno-exceptions -MT 
common/config.lo -MD -MP -MF common/.deps/config.Tpo -c 
common/config.cpp  -fPIC -DPIC -o common/.libs/config.o
g++: common/config.cpp: No such file or directory
g++: no input files
make[1]: *** [common/config.lo] Error 1
make[1]: Leaving directory `/home/ze/temp/j/aspell-0.60.5/build'
make: *** [all-recursive] Error 1
------------------

ls -l
-rw-r--r-- 1 digital digital  79584 Dec 19 03:03 ABOUT-NLS
-rw-r--r-- 1 digital digital 252919 Jan  5 19:27 aclocal.m4
drwxr-xr-x 3 digital digital   1024 Dec 19 05:21 auto/
drwxr-xr-x 2 digital digital   1024 Jan  5 19:27 autom4te.cache/
drwxr-xr-x 2 digital digital   2048 Jan  5 19:26 common/
-rwxr-xr-x 1 digital digital   3707 Nov 11 18:30 compile*
-rwxr-xr-x 1 digital digital  43668 Nov 11 18:32 config.guess*
-rwxr-xr-x 1 digital digital  16164 Nov 11 21:58 config.rpath*
-rwxr-xr-x 1 digital digital  32151 Nov 11 18:32 config.sub*
-rwxr-xr-x 1 digital digital 823736 Jan  5 19:27 configure*
-rw-r--r-- 1 digital digital  16041 Dec 19 03:02 configure.ac
-rw-r--r-- 1 digital digital  26430 Jul 29  2002 COPYING
drwxr-xr-x 2 digital digital   2048 Dec 19 05:21 data/
-rwxr-xr-x 1 digital digital  17574 Nov 11 18:30 depcomp*
drwxr-xr-x 2 digital digital   1024 Jan  5 19:27 examples/
drwxr-xr-x 2 digital digital   1024 Dec 19 05:21 gen/
-rwxr-xr-x 1 digital digital  13184 Nov 11 18:30 install-sh*
drwxr-xr-x 3 digital digital   1024 Dec 19 05:21 interfaces/
drwxr-xr-x 2 digital digital   1024 Dec 19 05:21 lib/
drwxr-xr-x 2 digital digital   1024 Jan  5 19:27 lib5/
-rw-r--r-- 1 digital digital 196440 Nov 11 18:32 ltmain.sh
drwxr-xr-x 2 digital digital   1024 Dec 19 05:21 m4/
drwxr-xr-x 2 digital digital   1024 Dec 19 05:21 maintainer/
-rw-r--r-- 1 digital digital  11330 Jan  5 19:26 Makefile.am
-rw-r--r-- 1 digital digital  79425 Jan  5 19:27 Makefile.in
drwxr-xr-x 4 digital digital   1024 Jan  5 19:27 manual/
drwxr-xr-x 2 digital digital   1024 Dec 19 05:21 misc/
-rwxr-xr-x 1 digital digital  11135 Nov 11 18:30 missing*
drwxr-xr-x 5 digital digital   1024 Dec 19 05:21 modules/
drwxr-xr-x 2 digital digital   1024 Jan  5 19:27 myspell/
drwxr-xr-x 2 digital digital   2048 Dec 19 05:21 po/
drwxr-xr-x 2 digital digital   1024 Dec 19 05:21 prog/
-rw-r--r-- 1 digital digital  16701 Nov 18 02:51 README
drwxr-xr-x 2 digital digital   1024 Dec 19 05:21 scripts/
-rw-r--r-- 1 digital digital     89 Jan  6  2004 TODO
drwxr-xr-x 2 digital digital   1024 Dec 19 05:21 win32/

timestamp okay, plus doing a "diff" between original and updated version of
Makefile.in shows substantial changes including the change you mentioned 
approximately around line 1880.

> After Makefile.in is regenerated "config.status --recheck" should
> automatically run when you try to make again.  (Or start from scratch.)

Yes, it started from scratch.
There was a "configure: creating ./config.status"
....followed by many lines recreated
There is a "config.status" in the "build" directory.

> Do the developers have a preferred way of regenerating files?  I noticed a
> maintainer/ directory with scripts like 'autogen'.  (Wasn't mentioned in
> the texinfo documentation.)

Kevin is the developer, people like us go around annoying him since we don't 
know the tools ;-)   however, a normal user like me shouldn't really need to 
go into the maintainer directory since things should usually work under the 
magic commands of (normally):
configure
make
make install

> I only jumped into this today with a quick 
> fix, so pardon me I'm not familiar with others' habits and conventions.

Not a problem. Your quick fix worked for you on a mac, but it seems not to 
work for me on a PC under this particular distribution. If you look at the 
bug list on sourceforge several bugs may possibly be fixed by what may 
sometimes seem like very "minor" fixes, but the main thing is to not break 
things for other users. For example, your minor fix could possibly open the 
door to fixing stuff like this:
http://sourceforge.net/tracker/index.php?func=detail&aid=1021597&group_id=245&atid=100245
and maybe even this as well:
http://sourceforge.net/tracker/index.php?func=detail&aid=1242556&group_id=245&atid=100245
and the configure options you mention could possibly open another door to 
trying stuff like "configure --other cpu" therefore opening up the 
possibility of seeing things like these without that particular CPU:
http://sourceforge.net/tracker/index.php?func=detail&aid=1504561&group_id=245&atid=100245
http://sourceforge.net/tracker/index.php?func=detail&aid=1498387&group_id=245&atid=100245

..so sometimes "minor" depends on who's point of view  :-)

Jose.