auctex-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch 1


From: Tassilo Horn
Subject: Re: patch 1
Date: Wed, 10 Jun 2020 20:23:20 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Uwe Brauer <oub@mat.ucm.es> writes:

Hi Uwe,

> -        style/tex-live.el
> +        style/tex-live.el  style/algorithm.el \
                                                 ^
Like in the other patch, no need for the \.

> +;; Copyright (C) 2016--2020 Free Software Foundation, Inc.
                    ^^^^^^^^^^
I think the year of adding it publicly is what's important here, not
the years you've maintained it privately.

> +(declare-function font-latex-add-keywords
> +               "font-latex"
> +               (keywords class))

You don't use it, so don't forward-declare it.

> +(TeX-add-style-hook
> + "algorithm"
> + (lambda ()
> +   (TeX-run-style-hooks "article")

Why is that needed?

> +   (LaTeX-add-environments
> +    '("algorithm"  LaTeX-env-algorithm ))
> +   (TeX-add-symbols
> +    '("listofalgorithms" 0))
> +   (add-to-list 'LaTeX-label-alist '("algorithm" . LaTeX-algorithm-label) t)
                                                      ^^^^^^^^^^^^^^^^^^^^^
That's not defined in the style...

Bye,
Tassilo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]