Re: Use of lexical binding plus various other things

[Arash Esbati]

Ikumi Keita <ikumi@ikumi.que.jp> writes:

>>>>>> Ikumi Keita <ikumi@ikumi.que.jp> writes:
>>>>>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> BTW, I rebased my branch on top of your patch, and hence on top of
>>> auctex.git's `master`.
>
>> Thanks, I'd like to merge them into AUCTeX repository. If nobody
>> objects, I'll do it soon.
>
> Merged.

Many thanks for this.  I ran `make' in tests directory and get the
following error (re-arranged for legibility):

    EMACSLOADPATH= LC_ALL=C  "emacs" -batch -L ".." -l ert -l \
    make-test-deps.emacs-lisp -l japanese/preview-latex.el \
    -f ert-run-tests-batch-and-exit 2>&1 | tee japanese/preview-latex.log

    Debugger entered--Lisp error: (error "Defining as dynamic an already 
lexical var")
      internal--define-uninitialized-variable(japanese-TeX-error-messages
      "If non-nil, explain TeX error messages in Japanese...")
      custom-declare-variable(japanese-TeX-error-messages
      (funcall #'#f(compiled-function () #<bytecode 0x1e0000153e5d>))
      "If non-nil, explain TeX error messages in Japanese..." :type boolean)

The following change seems to fix the issue.  Is this the right way?

--8<---------------cut here---------------start------------->8---
diff --git a/tests/japanese/preview-latex.el b/tests/japanese/preview-latex.el
index 95cc8ca2..d69b1105 100644
--- a/tests/japanese/preview-latex.el
+++ b/tests/japanese/preview-latex.el
@@ -22,8 +22,10 @@
 ;;; Code:

 (require 'ert)
-(let ((japanese-TeX-error-messages nil))
-  (require 'tex-jp))
+(let (_)
+  (defvar japanese-TeX-error-messages)
+  (let ((japanese-TeX-error-messages nil))
+    (require 'tex-jp)))
 (require 'preview)

 (AUCTeX-set-ert-path
--8<---------------cut here---------------end--------------->8---

Best, Arash