[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Automake-ng] [PATCH 1/4] [ng] compiling: implement VPATH rewrites u
From: |
Jim Meyering |
Subject: |
Re: [Automake-ng] [PATCH 1/4] [ng] compiling: implement VPATH rewrites using GNU make primitives |
Date: |
Wed, 01 Feb 2012 10:50:04 +0100 |
Stefano Lattarini wrote:
> This will shave off extra forks from compilation rules. No semantic
> change is expected from this commit. Suggestion from Eric Bake.
>
> * lib/am/depend2.am (am__vpath_rewrite): New internal macro,
> implements VPATH rewrites only using GNU make primitives.
> Use it in several compilation rules.
> ---
> lib/am/depend2.am | 25 ++++++++++++++-----------
> 1 files changed, 14 insertions(+), 11 deletions(-)
>
> diff --git a/lib/am/depend2.am b/lib/am/depend2.am
...
> +## Emulate VPATH rewrites. This only uses GNU make primitives, which
> +## allows us to avoid extra forks.
> +am__vpath_rewrite = $(firstword $(wildcard $(strip $(1))) $(srcdir)/$(strip
> $(1)))
Nice change.
At least when it's easy, as it is here, please try to limit
line length to 79 or 80:
am__vpath_rewrite = \
$(firstword $(wildcard $(strip $(1))) $(srcdir)/$(strip $(1)))
- [Automake-ng] [PATCH 0/4] Dependency tracking and compilation rules: some improvements, Stefano Lattarini, 2012/02/01
- [Automake-ng] [PATCH 2/4] [ng] compiling: remove some code duplication in depend2.am, Stefano Lattarini, 2012/02/01
- [Automake-ng] [PATCH 3/4] [ng] vpath: define generic make function for VPATH rewrites, Stefano Lattarini, 2012/02/01
- [Automake-ng] [PATCH 4/4] [ng] yacc, lex: fix subdir VPATH builds, Stefano Lattarini, 2012/02/01
- [Automake-ng] [PATCH 1/4] [ng] compiling: implement VPATH rewrites using GNU make primitives, Stefano Lattarini, 2012/02/01
- Re: [Automake-ng] [PATCH 1/4] [ng] compiling: implement VPATH rewrites using GNU make primitives,
Jim Meyering <=
- Re: [Automake-ng] [PATCH 0/4] Dependency tracking and compilation rules: some improvements, Stefano Lattarini, 2012/02/01