Re: [Automake-ng] [PATCH 3/4] [ng] vpath: define generic make function for VPATH rewrites

[Jim Meyering]

Stefano Lattarini wrote:
> This change generalize and make available to all the Automake

s/ze/zes/;s/make/makes/

> generated Makefiles a common idiom dealing with VPATH rewrites.
> This idiom has been introduced in the recent commits (see in

s/has been/was/;s/the /

> particular 'v1.11-1835-gcf93724').
>
> * lib/am/depend2.am (am__vpath_rewrite): Move ...
> * lib/am/header-vars.am: ... here.
> * tests/vpath-rewrite.test: New test.
> * tests/list-of-tests.mk: Add it.
> ---
>  lib/am/depend2.am        |    4 --
>  lib/am/header-vars.am    |    5 ++
>  tests/list-of-tests.mk   |    1 +
>  tests/vpath-rewrite.test |  100 
> ++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 106 insertions(+), 4 deletions(-)
>  create mode 100755 tests/vpath-rewrite.test
>
> diff --git a/lib/am/depend2.am b/lib/am/depend2.am
...
> +## Emulate VPATH rewrites.  This only uses GNU make primitives, which

s/only uses/uses only/

> +## allows us to avoid extra forks.
> +am__vpath_rewrite = \
> +  $(firstword $(wildcard $(strip $(1))) $(srcdir)/$(strip $(1)))
> +
>  ## We used to define this.  However, we don't because vendor makes
>  ## (e.g., Solaris, Irix) won't correctly propagate variables that are
>  ## defined in Makefile.  This particular variable can't be correctly
> diff --git a/tests/list-of-tests.mk b/tests/list-of-tests.mk
> index d590868..77f0d00 100644
> --- a/tests/list-of-tests.mk
> +++ b/tests/list-of-tests.mk
> @@ -1154,6 +1154,7 @@ version6.test \
>  version7.test \
>  version8.test \
>  vpath.test \
> +vpath-rewrite.test \
>  vtexi.test \
>  vtexi2.test \
>  vtexi3.test \
> diff --git a/tests/vpath-rewrite.test b/tests/vpath-rewrite.test
...
> +## FIXME: these two does not work apparently :-(  Such use cases are not

s/does/do/

> +## FIXME: required presently though, so this is not a big deal.
> +     : test '\$(call vr, bsub$tab  )'        = bsub
> +     : test '\$(call vr,bsub)'               = bsub