automake-ng
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Automake-ng] [PATCH 1/4] [ng] compiling: implement VPATH rewrites u


From: Jim Meyering
Subject: Re: [Automake-ng] [PATCH 1/4] [ng] compiling: implement VPATH rewrites using GNU make primitives
Date: Wed, 01 Feb 2012 13:55:04 +0100

Stefano Lattarini wrote:
>> Nice change.
>> At least when it's easy, as it is here, please try to limit
>> line length to 79 or 80:
>>
>> am__vpath_rewrite = \
>>   $(firstword $(wildcard $(strip $(1))) $(srcdir)/$(strip $(1)))

Hi Stefano,

> Good point.  Still, since the better line wrapping you proposed is already
> implemented later in [PATCH 3/4] (when we move the $(am__vpath_rewrite)
> definition from depend2.am to header-vars.am), could we just keep this patch
> as-is, to avoid unnecessary rebase pains?

Of course.
In any case, I pointed it out more as a general guideline than
for that particular instance.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]