[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Automake-NG] [PATCH 3/3] [ng] memoize: correctly work around a bug
From: |
Akim Demaille |
Subject: |
Re: [Automake-NG] [PATCH 3/3] [ng] memoize: correctly work around a bug of GNU make < 3.83 |
Date: |
Tue, 15 May 2012 13:44:22 +0200 |
Hi Stefano!
Le 15 mai 2012 à 12:44, Stefano Lattarini a écrit :
> +am__memoize = \
> + $(if $(am__memoized_value/$1),$(am__memoized_value/$1),$(strip \
> + $(eval am__memoized_value/$1 := $$2))$(am__memoized_value/$1))
If the result is large, we might be evaluating twice
am__memoized_value/$1 for no good reason. Can't $(or)
be used instead?
Or maybe uses $(origin) to implement ifndef.
But maybe my model of Make is wrong. I'm thinking like if
it were m4 here, in which case avoiding duplicate expansion
would be a Good Thing. If $(if) is basically O(1) for
:=-variables, there is no worry.
- Re: [Automake-NG] [PATCH] vars: implement make variable memoization (new function 'am__memoize'), (continued)
- Re: [Automake-NG] [PATCH] vars: implement make variable memoization (new function 'am__memoize'), Akim Demaille, 2012/05/14
- Re: [Automake-NG] [PATCH] vars: implement make variable memoization (new function 'am__memoize'), Stefano Lattarini, 2012/05/15
- [Automake-NG] [PATCH] memoize: expose a serious bug (for GNU make < 3.83), Stefano Lattarini, 2012/05/15
- Re: [Automake-NG] [PATCH] memoize: expose a serious bug (for GNU make < 3.83), Akim Demaille, 2012/05/15
- [Automake-NG] [PATCH 0/3] Fix variable memoization, Stefano Lattarini, 2012/05/15
- [Automake-NG] [PATCH 2/3] [ng] coverage: test memoize on variable with long name and long content, Stefano Lattarini, 2012/05/15
- [Automake-NG] [PATCH 1/3] [ng] memoize: expose a serious bug (affecting GNU make < 3.83), Stefano Lattarini, 2012/05/15
- [Automake-NG] [PATCH 3/3] [ng] memoize: correctly work around a bug of GNU make < 3.83, Stefano Lattarini, 2012/05/15
- Re: [Automake-NG] [PATCH 3/3] [ng] memoize: correctly work around a bug of GNU make < 3.83,
Akim Demaille <=
- Re: [Automake-NG] [PATCH 3/3] [ng] memoize: correctly work around a bug of GNU make < 3.83, Stefano Lattarini, 2012/05/15
- Re: [Automake-NG] [PATCH 3/3] [ng] memoize: correctly work around a bug of GNU make < 3.83, Akim Demaille, 2012/05/15
- Re: [Automake-NG] [PATCH 3/3] [ng] memoize: correctly work around a bug of GNU make < 3.83, Stefano Lattarini, 2012/05/15
- Re: [Automake-NG] [PATCH 3/3] [ng] memoize: correctly work around a bug of GNU make < 3.83, Stefano Lattarini, 2012/05/16
- Re: [Automake-NG] [PATCH 0/3] Fix variable memoization, Akim Demaille, 2012/05/15
Re: [Automake-NG] [PATCH 00/11] Several changes to parallel-tests support, Bob Friesenhahn, 2012/05/09
[Automake-NG] [PATCH 0/2] Nice optimization for the parallel-tests harness, Stefano Lattarini, 2012/05/16