Re: [Automake-NG] [PATCH] vars: implement make variable memoization (new function 'am__memoize')

[Stefano Lattarini]

On 05/13/2012 03:39 PM, Dave Hart wrote:
> On Sun, May 13, 2012 at 11:16 AM, Stefano Lattarini
> <address@hidden> wrote:
>> "Immediate" variables (deriving from assignments like "var := value")
>> are better in this respect, since their definition evaluates the LHS
>> immediately, and only once.
> 
> s/LHS/RHS/ here and several more instances.
>
Oops, fixed now.

> Also it might be worth spelling it out the first time you use the term RHS.
>
Good point.  Consider it done.

>> +## This API and implementation seems to work around a bug in GNU make
>> +## (present up to and including 3.82) which caused our first
>> +## implementation attempt to fail:
>> +##   <http://lists.gnu.org/archive/html/bug-make/2012-05/msg00013.html>
>> +##   <https://savannah.gnu.org/patch/?7534>
>> +## So please don't change this without a very goo reason.
> 
> s/goo/good/
>
Fixed as well.

I've also noticed another typo in the commit message ("founnd"), and fixed
that as well.

Thanks for the review,
  Stefano