[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Automake-NG] [PATCH 0/3] Fix variable memoization
From: |
Stefano Lattarini |
Subject: |
[Automake-NG] [PATCH 0/3] Fix variable memoization |
Date: |
Tue, 15 May 2012 12:44:32 +0200 |
Akim Demaille wrote:
> It is my understanding that the bug prevents reassigning to a
> variable, right? So maybe the outer variable, instead of trying
> to memoize, could use an $(if) to branch either to evaluate-and-store
> in *another* variable else to the value of this memo variable.
>
> This should prevent re-assignment, and result is the sole
> extra cost of check whether the memo-variable was set.
>
Wow, you are a goldmine of good ideas :-)
I've followed your advice, and indeed your approach seems to work (not
to mention that it offers better APIs). So I now propose to apply these
three patches on the top of the current 'ng/master' branch.
OK?
Thanks,
Stefano
-*-*-*-
Stefano Lattarini (3):
[ng] memoize: expose a serious bug (affecting GNU make < 3.83)
[ng] coverage: test memoize on variable with long name and long content
[ng] memoize: correctly work around a bug of GNU make < 3.83
lib/am/header-vars.am | 14 ++++---
t/memoize.tap | 112 +++++++++++++++++++++++++++----------------------
t/spy-override.sh | 51 ----------------------
3 files changed, 71 insertions(+), 106 deletions(-)
delete mode 100755 t/spy-override.sh
--
1.7.9.5
- Re: [Automake-NG] [PATCH 00/11] Several changes to parallel-tests support, (continued)
- Re: [Automake-NG] [PATCH 00/11] Several changes to parallel-tests support, Akim Demaille, 2012/05/11
- Re: [Automake-NG] [PATCH 00/11] Several changes to parallel-tests support, Akim Demaille, 2012/05/11
- Re: [Automake-NG] [PATCH 00/11] Several changes to parallel-tests support, Stefano Lattarini, 2012/05/11
- [Automake-NG] [PATCH] vars: implement make variable memoization (new function 'am__memoize'), Stefano Lattarini, 2012/05/13
- Re: [Automake-NG] [PATCH] vars: implement make variable memoization (new function 'am__memoize'), Dave Hart, 2012/05/13
- Re: [Automake-NG] [PATCH] vars: implement make variable memoization (new function 'am__memoize'), Stefano Lattarini, 2012/05/13
- Re: [Automake-NG] [PATCH] vars: implement make variable memoization (new function 'am__memoize'), Akim Demaille, 2012/05/14
- Re: [Automake-NG] [PATCH] vars: implement make variable memoization (new function 'am__memoize'), Stefano Lattarini, 2012/05/15
- [Automake-NG] [PATCH] memoize: expose a serious bug (for GNU make < 3.83), Stefano Lattarini, 2012/05/15
- Re: [Automake-NG] [PATCH] memoize: expose a serious bug (for GNU make < 3.83), Akim Demaille, 2012/05/15
- [Automake-NG] [PATCH 0/3] Fix variable memoization,
Stefano Lattarini <=
- [Automake-NG] [PATCH 2/3] [ng] coverage: test memoize on variable with long name and long content, Stefano Lattarini, 2012/05/15
- [Automake-NG] [PATCH 1/3] [ng] memoize: expose a serious bug (affecting GNU make < 3.83), Stefano Lattarini, 2012/05/15
- [Automake-NG] [PATCH 3/3] [ng] memoize: correctly work around a bug of GNU make < 3.83, Stefano Lattarini, 2012/05/15
- Re: [Automake-NG] [PATCH 3/3] [ng] memoize: correctly work around a bug of GNU make < 3.83, Akim Demaille, 2012/05/15
- Re: [Automake-NG] [PATCH 3/3] [ng] memoize: correctly work around a bug of GNU make < 3.83, Stefano Lattarini, 2012/05/15
- Re: [Automake-NG] [PATCH 3/3] [ng] memoize: correctly work around a bug of GNU make < 3.83, Akim Demaille, 2012/05/15
- Re: [Automake-NG] [PATCH 3/3] [ng] memoize: correctly work around a bug of GNU make < 3.83, Stefano Lattarini, 2012/05/15
- Re: [Automake-NG] [PATCH 3/3] [ng] memoize: correctly work around a bug of GNU make < 3.83, Stefano Lattarini, 2012/05/16
- Re: [Automake-NG] [PATCH 0/3] Fix variable memoization, Akim Demaille, 2012/05/15
Re: [Automake-NG] [PATCH 00/11] Several changes to parallel-tests support, Bob Friesenhahn, 2012/05/09