[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Incorrect use of USE_XATTR in coreutils-8.4
From: |
Adam Sampson |
Subject: |
Incorrect use of USE_XATTR in coreutils-8.4 |
Date: |
Sat, 16 Jan 2010 11:42:36 +0000 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
Hiya,
I've just built coreutils 8.4 on a machine with libattr installed, and
found that tests/cp/cp-mv-enotsup-xattr was failing because cp was
incorrectly giving the "cp is built without xattr support" error
message. The problem appears to be that the configure script defines
USE_XATTR to "yes" if attr support is enabled, but copy.c and cp.c use
"#if USE_XATTR"/"#if !USE_XATTR" to test it. The attached patch changes
these to use #ifdef/#ifndef, which makes the testsuite pass for me.
Thanks,
--
Adam Sampson <address@hidden> <http://offog.org/>
usexattr.diff
Description: Text document
- Incorrect use of USE_XATTR in coreutils-8.4,
Adam Sampson <=
- Re: Incorrect use of USE_XATTR in coreutils-8.4, Eric Blake, 2010/01/16
- Re: Incorrect use of USE_XATTR in coreutils-8.4, Pádraig Brady, 2010/01/16
- Re: Incorrect use of USE_XATTR in coreutils-8.4, Eric Blake, 2010/01/16
- Re: Incorrect use of USE_XATTR in coreutils-8.4, Jim Meyering, 2010/01/17
- Re: Incorrect use of USE_XATTR in coreutils-8.4, Pádraig Brady, 2010/01/18
- Re: Incorrect use of USE_XATTR in coreutils-8.4, Pádraig Brady, 2010/01/22
- Re: Incorrect use of USE_XATTR in coreutils-8.4, Jim Meyering, 2010/01/22
- Re: Incorrect use of USE_XATTR in coreutils-8.4, Eric Blake, 2010/01/22
- Re: Incorrect use of USE_XATTR in coreutils-8.4, Jim Meyering, 2010/01/22
- Re: Incorrect use of USE_XATTR in coreutils-8.4, Pádraig Brady, 2010/01/25