|
From: | Pádraig Brady |
Subject: | Re: Incorrect use of USE_XATTR in coreutils-8.4 |
Date: | Sat, 16 Jan 2010 16:33:20 +0000 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091204 Thunderbird/3.0 |
On 16/01/10 11:42, Adam Sampson wrote:
Hiya, I've just built coreutils 8.4 on a machine with libattr installed, and found that tests/cp/cp-mv-enotsup-xattr was failing because cp was incorrectly giving the "cp is built without xattr support" error message. The problem appears to be that the configure script defines USE_XATTR to "yes" if attr support is enabled, but copy.c and cp.c use "#if USE_XATTR"/"#if !USE_XATTR" to test it. The attached patch changes these to use #ifdef/#ifndef, which makes the testsuite pass for me.
Sigh. That test was skipped for me as it was depending on the host filesystem supporting user_xattr. Attached patch removes that dependency, and also fixes it so we won't fail when USER_XATTR is 0. Eric, you forgot to attached your patch. cheers, Pádraig.
cp-mv-enotsup-xattr-fix.diff
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |