bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Incorrect use of USE_XATTR in coreutils-8.4


From: Eric Blake
Subject: Re: Incorrect use of USE_XATTR in coreutils-8.4
Date: Sat, 16 Jan 2010 10:31:23 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666

According to Pádraig Brady on 1/16/2010 9:33 AM:
> Eric, you forgot to attached your patch.
> 

Oops.

-- 
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
From e8115ecac17b200edc07fc057e7d31788fb4c2fd Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Sat, 16 Jan 2010 06:46:17 -0700
Subject: [PATCH] build: fix build failure of bogus USE_XATTR

* m4/xattr.m4 (gl_FUNC_ADDR): Fix regression introduced in commit
6beca4248.
* THANKS: Update.
Reported by Adam Sampson.
---
 THANKS      |    1 +
 m4/xattr.m4 |    6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/THANKS b/THANKS
index 583ea60..1207368 100644
--- a/THANKS
+++ b/THANKS
diff --git a/m4/xattr.m4 b/m4/xattr.m4
index bf7e872..d32a7f3 100644
--- a/m4/xattr.m4
+++ b/m4/xattr.m4
@@ -1,4 +1,5 @@
 # xattr.m4 - check for Extended Attributes (Linux)
+# serial 3

 # Copyright (C) 2003, 2008-2010 Free Software Foundation, Inc.
 # This file is free software; the Free Software Foundation
@@ -33,11 +34,12 @@ AC_DEFUN([gl_FUNC_XATTR],
         use_xattr=yes
       fi
     fi
-    AC_DEFINE_UNQUOTED([USE_XATTR], [$use_xattr],
-                       [Define if you want extended attribute support.])
     if test $use_xattr = no; then
       AC_MSG_WARN([libattr development library was not found or not usable.])
       AC_MSG_WARN([AC_PACKAGE_NAME will be built without xattr support.])
+    else
+      AC_DEFINE([USE_XATTR], [1],
+                [Define if you want extended attribute support.])
     fi
   fi
 ])
-- 
1.6.4.2

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]