Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

[Richard van den Berg]

On 5/24/09 2:33 AM, H. Langos wrote:
> One thing to keep in mind is that the --min-vol-adj and --max-vol-adj now
> only affect the RVA/RVAD tag information instead of something extracted 
> from RVA2 tags. (I need to update the help text about that.)
>   

Since RVA2 now changes the SoundCheck field in the iTunesDB it can still 
be ignored by disabling Sound Check on the iPod.

> Those options were probably introduced because having iTunNORM comments AND
> RVA2 tags on one file would have led to very loud results.
>   

No, I think they were introduced because the volume fields in the 
iTunesDB always get applied on the iPod. Without any switches to gnupod, 
the user would have no control over the volume other than somehow 
changing the tags in the files. (iTunes has the volume slider per track 
for this purpose.)

> Now RVA2/XRVA tags are read instead of iTunNORM comments and we might either
> get rid of those options or supplement them with --min-db-adj and
> --max-db-adj to limit the adjustment that goes into the soundcheck
> attribute. 
>   

I don't think that's needed. If a user has files with 
RVA2/XRVA/iTunNORM/ReplayGain tags that do not work for him, he can 
always disable Sound Check on the iPod and they will all be ignored.

Cheers,

Richard