[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #3588] Patch to make m4 compile under MingW

From: Eric Blake
Subject: [patch #3588] Patch to make m4 compile under MingW
Date: Mon, 29 May 2006 09:28:07 -0600
User-agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.5) Gecko/20060111 Netscape/8.1

Update of patch #3588 (project m4):

             Assigned to:                    None => ericb                  


Follow-up Comment #4:

It looks like you changed 'cmp -s' to 'diff -wq' in order to ignore
whitespace.  Neither -w nor -q are portable diff options, so I am hesitant to
check in your proposed change to check-them, although it certainly highlights
how line-endings on text mode files are a definite factor.  I would rather
investigate a patch that makes m4 open all files in binary mode on platforms
where O_BINARY is defined.  Meanwhile, could you give more details about the
failing tests, beyond just the names?  Also, would you be willing to try
branch-1_4 in CVS, so we can have feedback on the upcoming 1.4.5 release?


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]