Re: [Bug-wget] [PATCH v4] Make wget capable of starting download from a specified position.

[Tim Ruehsen]

First of all, thanks for your contribution.

I have some little remarks / questions:

- The documentation is not quite right: when using --start-pos and the file 
already exists, wget creates as expected a file.1.
But your docs say, --start-pos would overwrite an existing file !?
Could you make this point clear ?

- The combination with --continue works for me as expected. It would simply 
append the downloaded bytes to the existing file. Maybe you should document 
that as well. At least your sentence "... it would override the behavior of --
continue" seems not to be correct.

- What about extending the option to something like --range=STARTPOS[-ENDPOS] 
?

- If you want to brush up your patch, add a test-case for it for the new 
Python based test suite. I guess, Darshit can give you a helping hand, if you 
request it.

Tim

>       --start-pos is zero-based.
> 
> v2 -> v3
> 
>         Fix a typo and add description text for the new option into the
> usage output.  Thank Darshit Shah <address@hidden> for the suggestions.
> 
> v1 -> v2
> 
>         It was kindly pointed out by Darshit Shah <address@hidden> that
>         server support for resuming download is required, so adding this
> into doc/wget.texi.
> 
>  doc/ChangeLog |    4 ++++
>  doc/wget.texi |   17 +++++++++++++++++
>  src/ChangeLog |    9 +++++++++
>  src/ftp.c     |    2 ++
>  src/http.c    |    2 ++
>  src/init.c    |    1 +
>  src/main.c    |    3 +++
>  src/options.h |    1 +
>  8 files changed, 39 insertions(+), 0 deletions(-)