[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH v4] Make wget capable of starting download from a
Re: [Bug-wget] [PATCH v4] Make wget capable of starting download from a specified position.
Thu, 13 Feb 2014 09:23:14 +0100
KMail/4.11.5 (Linux/3.12-1-amd64; KDE/4.11.5; x86_64; ; )
On Thursday 13 February 2014 11:32:24 Yousong Zhou wrote:
> Thank you, Tim. I appreciate your help and suggestion. Just got my
> internet connection back, sorry for the delayed response.
> I will try to review and enhance my implementation then send a new patch.
> - Forbid the presence of both `--start-pos` and `--continue` which
> makes little sense.
> - Zero-based offset position is fine at first glance, but not
> appropriate when used as a bool value, i.e. `if(opt.start_pos) ...`.
> I will try to polish the current zero-based solution, but may change
> it to 1 based if there is not acceptable workaround.
It might be good to stay with 0 based offsets. Just use a default of -1 for
opt.start_pos and check 'if (opt.start_pos != -1)'. With this, one can disable
the option on the command line (e.g. if it is set in wgetrc).
> - Add test cases for the new feature.
Sounds good ;-)