Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

[Tim Ruehsen]

Hi Dagobert, hi Ander,

I could reproduce and fix the problem on a 32bit Debian wheezy VM.

@Dagobert Please check if the attached patch works on Solaris as well
@Ander Please review that I did not get anything wrong

Tim

On Tuesday 17 November 2015 21:21:00 Dagobert Michelsen wrote:
> Hi Tim,
> 
> Am 17.11.2015 um 21:17 schrieb Tim Rühsen <address@hidden>:
> > Am Dienstag, 17. November 2015, 15:09:05 schrieb Dagobert Michelsen:
> >>> RUNNING TEST test_hsts_url_rewrite_superdomain...
> >>> A new entry should've been created
> >>> Tests run: 15
> >>> FAIL unit-tests (exit status: 1)
> >> 
> >> So which test is failing? test_hsts_url_rewrite_superdomain ?
> >> There is no *hsts* in tests/
> > 
> > Could you please change L689 of src/hsts.c from
> > 
> >  created = hsts_store_entry (s, SCHEME_HTTPS, "www.foo.com", 443,
> >  time(NULL)
> > 
> > + 1234, true);
> > 
> > to
> > 
> >  created = hsts_store_entry (s, SCHEME_HTTPS, "www.foo.com", 443, 1234,
> > 
> > true);
> > 
> > and give it a try ?
> 
> Sorry, still fails.
> 
> 
> Best regards
> 
>   — Dago
> 
> --
> "You don't become great by trying to be great, you become great by wanting
> to do something, and then doing it so hard that you become great in the
> process." - xkcd #896

0001-Fix-HSTS-memory-issue-test-code-issue.patch
Description: Text Data