Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

[Tim Rühsen]

Am Samstag, 12. Dezember 2015, 17:57:00 schrieb Darshit Shah:
> Didn't we fix this by using the Gnulib module?
> I thought all the tests were passing on Solaris after that. What went
> wrong with the release?
> Immediately after the release, even the Solaris buildbot complained
> about a broken build.

I thought that the buildbot runs on each push to git repository !?
If so, how can the last commit (the 1.17.1 tagged commit) cause a failure on 
did not come up before ? Bug in the gnulib module ?


The error does tell me nothing:
(This is from the buildbot output)

gmake[3]: Entering directory '/export/home/buildbot/slave/wget-solaris10-
i386/build/src'
/opt/csw/bin/gcc -DHAVE_CONFIG_H -DSYSTEM_WGETRC=\"/usr/local/etc/wgetrc\" -
DLOCALEDIR=\"/usr/local/share/locale\" -I.  -I../lib -I../lib -D_REENTRANT  -
I/opt/csw/include   -I/opt/csw/include -I/opt/csw/include   -I/opt/csw/include 
-I/opt/csw/include/p11-kit-1   -DHAVE_LIBGNUTLS -I/opt/csw/include   -
I/opt/csw/include   -DNDEBUG  -MT connect.o -MD -MP -MF .deps/connect.Tpo -c -
o connect.o connect.c
In file included from /usr/include/sys/types.h:17:0,
                 from ../lib/sys/types.h:28,
                 from sysdep.h:85,
                 from wget.h:47,
                 from connect.c:32:
/opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-
fixed/sys/feature_tests.h:346:2: error: #error "Compiler or options invalid 
for pre-UNIX 03 X/Open applications     and pre-2001 POSIX applications"
 #error "Compiler or options invalid for pre-UNIX 03 X/Open applications \
  ^

Tim

> 
> On 12 December 2015 at 17:42, Christian Jullien <address@hidden> wrote:
> > Hi, trying to compile wget-1.17 and now wget-1.17.1 on solaris 10 sparc
> > using gcc  5.2.0 , I get:
> > 
> > 
> > 
> > hsts.c:505:11: warning: implicit declaration of function 'flock'
> > [-Wimplicit-function-declaration]
> > 
> >            flock (fd, LOCK_EX);
> >            
> >            ^
> > 
> > hsts.c:505:22: error: 'LOCK_EX' undeclared (first use in this function)
> > 
> >            flock (fd, LOCK_EX);
> >            
> >                       ^
> > 
> > hsts.c:505:22: note: each undeclared identifier is reported only once for
> > each function it appears in
> > 
> > Makefile:1573: recipe for target 'hsts.o' failed
> > 
> > 
> > 
> > I solved compilation issue by replacing flock (line 505) by lockf which is
> > (POSIX.1-2001)
> > 
> > =>          lockf (fd, F_LOCK, 0);
> > 
> > 
> > 
> > Hope it helps.
> > 
> > 
> > 
> > Christian