Re: [Chicken-hackers] [PATCH] sequence type corrections and enhancements

[Felix]

From: Peter Bex <address@hidden>
Subject: Re: [Chicken-hackers] [PATCH] sequence type corrections and 
enhancements
Date: Wed, 14 Sep 2011 10:25:14 +0200

> On Wed, Sep 14, 2011 at 03:52:58AM -0400, Felix wrote:
>> > On Wed, Sep 14, 2011 at 12:51:55AM +0200, Felix wrote:
>> >> > 
>> >> > I think you overlooked these entries:
>> >> > 
>> >> > - reverse: argument and result
>> >> > - member, assv, assoc: specialization types
>> >> > 
>> >> > Also, member has a (forall a) in its declaration but doesn't use it,
>> >> > which looks wrong to me.
>> >> > 
>> >> > Further, "set-groups!" from POSIX is declared to accept a generic list.
>> >> > This could probably be improved to (list-of (or fixnum number)), I 
>> >> > think.
>> >> > 
>> >> 
>> >> Thanks for pointing this out. If you are willing to sign off and
>> >> apply this patch, I'd like to fix that in a different one.
>> > 
>> > I have no idea how this works.  Just saying "I'm okay with it" and
>> > merging it in from your branch?
>> 
>> For example. You can also use "git commit --amend" to modify the commit
>> message of the current branch tip after you merged or cherry-picked.
>> Well, that is what I think it does.
> 
> I have no idea how to apply several patches with cherry-pick.
> There's three patches now, one of which neccessary to resolve conflicts
> which means I can't apply them one by one.
> 
> Can someone please explain how the hell to apply patches like this?
> I can't merge because this will apply all patches and won't skip the
> one from the other message.

Sorry, that was me messing things up. I will prepare a new patch that
you can cherrypick.


cheers,
felix