chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] Remove old variant of find-files


From: Peter Bex
Subject: Re: [Chicken-hackers] Remove old variant of find-files
Date: Thu, 22 Sep 2011 10:45:08 +0200
User-agent: Mutt/1.4.2.3i

On Thu, Sep 22, 2011 at 10:38:50AM +0200, Moritz Heidkamp wrote:
> 
> Christian Kellermann <address@hidden> writes:
> > this is a simple patch to remove the deprecated variant of find-files.
> > As it is now the old variant is always choosen when calling find-files
> > with just 1 argument.
> 
> Looks good to me! I don't really get that "we want `cons' inlined"
> comment in the original version. Why doesn't direct passing of cons lead
> to inlining?

Don't understand that one either.

> > There is one discrepancy left as we do follow symlinks by default
> > and the docs say the opposite. Which way is the better behaviour?
> > I will change either the default or the docs then.
> 
> I'm not entirely sure what would be a sensible default myself. FWIW the
> GNU find program doesn't follow symlinks by default.

I think that's safer since symlinks can create cycles which might cause
an endless loop.  If in doubt, choose the safe option, to make it harder
to accidentally shoot yourself in the foot :)
(or do we have cycle detection?)

Cheers,
Peter
-- 
http://sjamaan.ath.cx
--
"The process of preparing programs for a digital computer
 is especially attractive, not only because it can be economically
 and scientifically rewarding, but also because it can be an aesthetic
 experience much like composing poetry or music."
                                                        -- Donald Knuth



reply via email to

[Prev in Thread] Current Thread [Next in Thread]