chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] address@hidden: Re: 4.8.0 release?]


From: Mario Domenech Goulart
Subject: Re: [Chicken-hackers] address@hidden: Re: 4.8.0 release?]
Date: Tue, 11 Sep 2012 11:46:37 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux)

On Tue, 11 Sep 2012 00:03:40 -0400 John Cowan <address@hidden> wrote:

> Mario Domenech Goulart scripsit:
>
>>  # for cygwin
>> -test -f ../cygchicken-0.dll && cp ../cygchicken-0.dll .
>> +if test -f ../cygchicken-0.dll; then
>> +    cp ../cygchicken-0.dll .
>> +    cp ../cygchicken-0.dll reverser/tags/1.0
>> +fi
>> +mv ../cygchicken-0.dll ../cygchicken-0.dll_
>
> All these copies and moves, including the last, need to be inside the
> scope of the "if test -f", or it's not idempotent.

Indeed, John.  Thanks for noticing that.  Attached is an updated version
of the patch.

I tested it on master, and I could "make ... spotless install check"
successfully.

Best wishes.
Mario
-- 
http://parenteses.org/mario

Attachment: cygwin-fixes.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]