[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Chicken-hackers] [PATCH] [5] Let's get rid of ##sys#fudge

From: Peter Bex
Subject: [Chicken-hackers] [PATCH] [5] Let's get rid of ##sys#fudge
Date: Fri, 14 Oct 2016 22:24:29 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

Hi all,

This ##sys#fudge stuff has bothered me for a long time.  It's an obscure
name and it uses magic numbers, which means almost every use includes a
comment that says what it's doing.  Historically, some fudges have
disappeared, leaving gaps in the switch() statement, and there are
several values in there that are accessible in other ways.

I think it's a good idea to remove it.  This will also reduce runtime.c
in size a little bit.  It's 100% safe to remove; there are no hidden
dependencies in build bootstrapping or anything.  I think the main reason
it was kept all this time is because some eggs might use it.  We're
allowed to break compat now, so it's a good moment to do this.

Attached are a LOT of patches (9 in total).  Don't let that scare you,
I tried to keep them all relatively small and self-contained, so it's
hopefully easier to review them individually instead of doing it one
huge patch.

I took the most straightforward approach (I think) in most cases.  Some
of these patches can probably be improved on.  We can do this beforehand,
or after these changes are applied.

I noticed that the srfi-18 egg is using (##sys#fudge 12).  This can be
replaced with (##core#inline "C_i_tty_forcedp()") instead, now.


Attachment: 0001-Replace-uses-of-sys-fudge-7-by-C_wordstobytes.patch
Description: Text Data

Attachment: 0002-Replace-sys-fudge-3-by-64bit-feature-checks.patch
Description: Text Data

Attachment: 0003-Remove-a-few-obsolete-fudge-factors.patch
Description: Text Data

Attachment: 0004-Use-C_gui_mode-directly-remove-OS-specific-fudges.patch
Description: Text Data

Attachment: 0005-Remove-a-few-more-semi-unused-fudge-factors.patch
Description: Text Data

Attachment: 0006-Replace-fudges-with-readily-available-variables.patch
Description: Text Data

Attachment: 0007-Replace-CHICKEN-version-fudges-with-foreign-values.patch
Description: Text Data

Attachment: 0008-Add-helper-functions-for-remaining-fudge-factors.patch
Description: Text Data

Attachment: 0009-Finally-remove-all-traces-of-sys-fudge-C_fudge.patch
Description: Text Data

Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]