Re: Assertion failure

[Mark Wielaard]

Hi,

On Tue, 2006-01-10 at 19:26 +0100, Mark Wielaard wrote:
> Agreed. I am still hoping someone has a good analysis of the issue, or
> wants to upgrade our mprec to the newlib version. If not we should
> indeed disable the assert again before 0.20 is released.

Which is what I did. For now we just disabled the assert to get us the
behavior we had before. After 0.20 we should solve this correctly. I
have updated the bug report to mention the things discussed in the two
threads about this.

2006-01-12  Mark Wielaard  <address@hidden>

        * native/fdlibm/mprec.c (Balloc): Disable assert to workaround
        PR classpath/23863.

This solves all mauve regressions we were seeing.
It would be appreciated if others could also rerun their tests with this
applied.

Committed,

Mark


diff -u -r1.6 mprec.c
--- native/fdlibm/mprec.c       6 Jan 2006 01:27:20 -0000       1.6
+++ native/fdlibm/mprec.c       12 Jan 2006 09:20:55 -0000
@@ -97,7 +97,9 @@
   int i = 0;
   int j = 1;

-  assert ((1 << k) < MAX_BIGNUM_WDS);
+  /* FIXME - assert disabled because of PR classpath/23863
+   * assert ((1 << k) < MAX_BIGNUM_WDS);
+   */

   while ((ptr->_allocation_map & j) && i < MAX_BIGNUMS)
     i++, j <<= 1;

signature.asc
Description: This is a digitally signed message part