I ran the tests (with python2.6 and 2.7 both installed & tested against) but I'm facing linting & pep8 test errors, and offending files are not part of my modification (detailed error messages at the end of my mail) and test errors happen without my patch (on r1130) too.
I'm curious -- what do we do under this kind of circumstances? (As far as my original patch is concerned, though, I'll proceed with Kenneth's comments)
======================================================================
FAIL: test_pep8 (testing.test_code.CodeTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/mnjul/Documents/duplicity/testing/test_code.py", line 96, in test_pep8
os.path.join(_top_dir, 'bin/rdiffdir')])
File "/home/mnjul/Documents/duplicity/testing/test_code.py", line 40, in run_checker
self.assertTrue(process.returncode in returncodes, output)
AssertionError: /home/mnjul/Documents/duplicity/duplicity/collections.py:142:21: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:143:21: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:144:21: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:145:21: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:166:21: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:167:21: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:168:21: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:325:21: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:326:21: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:775:22: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:784:22: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:801:22: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/dup_threading.py:45:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/duplicity/dup_threading.py:47:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/duplicity/lazy.py:159:13: E731 do not assign a lambda _expression_, use a def
/home/mnjul/Documents/duplicity/duplicity/lazy.py:161:13: E731 do not assign a lambda _expression_, use a def
/home/mnjul/Documents/duplicity/duplicity/lazy.py:424:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/duplicity/lazy.py:425:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/duplicity/lazy.py:426:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/duplicity/robust.py:46:14: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/robust.py:67:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/duplicity/robust.py:68:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/duplicity/robust.py:69:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/duplicity/selection.py:156:25: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/selection.py:436:13: E731 do not assign a lambda _expression_, use a def
/home/mnjul/Documents/duplicity/duplicity/selection.py:552:13: E731 do not assign a lambda _expression_, use a def
/home/mnjul/Documents/duplicity/duplicity/selection.py:555:13: E731 do not assign a lambda _expression_, use a def
/home/mnjul/Documents/duplicity/duplicity/selection.py:620:33: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/tarfile.py:34:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:58:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:61:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:63:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:64:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:65:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:66:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:67:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:68:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:69:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:70:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:71:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:72:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:73:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:74:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:75:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:76:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:77:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:78:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:124:9: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:125:14: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:126:9: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:131:9: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:132:14: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:133:9: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:160:11: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:161:11: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:162:11: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:168:11: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:169:11: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:170:11: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:895:20: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:907:20: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:908:20: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:1186:28: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:1189:28: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:1237:22: W503 line break before binary operator
======================================================================
FAIL: test_pylint (testing.test_code.CodeTest)
Pylint test (requires pylint to be installed to pass)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/mnjul/Documents/duplicity/testing/test_code.py", line 84, in test_pylint
[0, 32])
File "/home/mnjul/Documents/duplicity/testing/test_code.py", line 40, in run_checker
self.assertTrue(process.returncode in returncodes, output)
AssertionError: ************* Module duplicity.backends.giobackend
E0712: 96: Catching an exception which doesn't inherit from BaseException: GError
E0712: 105: Catching an exception which doesn't inherit from BaseException: GError
----------------------------------------------------------------------