duplicity-talk
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Duplicity-talk] Unit test errors -- what to do? (was: Support for A

From: John
Subject: Re: [Duplicity-talk] Unit test errors -- what to do? (was: Support for AWS S3 "Infrequent Access" Storage Option)
Date: Sun, 11 Oct 2015 00:52:37 -0400
Well, the errors came with fully automated tox run (| cd testing; ./run-tests | or just | tox |).

I encounter the same errors if I run tests manually by | tox -- -s testing.test_code.CodeTest |.

Not sure what's the culprit here. My pylint and pep8 are installed through pip; their version is 1.4.4 and 1.6.2, respectively.


2015-10-10 6:41 GMT-04:00 Kenneth Loafman <address@hidden>:
The tests all pass when running tox here, with all of your changes, so I'm guessing that you are running the tests manually.  Try running with tox and things should work.  Let us know.

...Ken


On Fri, Oct 9, 2015 at 7:34 PM, Min-Zhong "John" Lu / 呂敏中 <address@hidden> wrote:
Hi Aaron & everyone,

I ran the tests (with python2.6 and 2.7 both installed & tested against) but I'm facing linting & pep8 test errors, and offending files are not part of my modification (detailed error messages at the end of my mail) and test errors happen without my patch (on r1130) too.

I'm curious -- what do we do under this kind of circumstances? (As far as my original patch is concerned, though, I'll proceed with Kenneth's comments)

My best,
John

(begin of test error msg)

======================================================================
FAIL: test_pep8 (testing.test_code.CodeTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/mnjul/Documents/duplicity/testing/test_code.py", line 96, in test_pep8
    os.path.join(_top_dir, 'bin/rdiffdir')])
  File "/home/mnjul/Documents/duplicity/testing/test_code.py", line 40, in run_checker
    self.assertTrue(process.returncode in returncodes, output)
AssertionError: /home/mnjul/Documents/duplicity/duplicity/collections.py:142:21: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:143:21: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:144:21: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:145:21: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:166:21: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:167:21: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:168:21: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:325:21: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:326:21: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:775:22: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:784:22: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/collections.py:801:22: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/dup_threading.py:45:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/duplicity/dup_threading.py:47:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/duplicity/lazy.py:159:13: E731 do not assign a lambda _expression_, use a def
/home/mnjul/Documents/duplicity/duplicity/lazy.py:161:13: E731 do not assign a lambda _expression_, use a def
/home/mnjul/Documents/duplicity/duplicity/lazy.py:424:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/duplicity/lazy.py:425:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/duplicity/lazy.py:426:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/duplicity/robust.py:46:14: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/robust.py:67:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/duplicity/robust.py:68:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/duplicity/robust.py:69:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/duplicity/selection.py:156:25: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/selection.py:436:13: E731 do not assign a lambda _expression_, use a def
/home/mnjul/Documents/duplicity/duplicity/selection.py:552:13: E731 do not assign a lambda _expression_, use a def
/home/mnjul/Documents/duplicity/duplicity/selection.py:555:13: E731 do not assign a lambda _expression_, use a def
/home/mnjul/Documents/duplicity/duplicity/selection.py:620:33: W503 line break before binary operator
/home/mnjul/Documents/duplicity/duplicity/tarfile.py:34:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:58:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:61:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:63:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:64:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:65:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:66:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:67:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:68:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:69:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:70:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:71:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:72:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:73:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:74:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:75:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:76:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:77:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:78:1: E402 module level import not at top of file
/home/mnjul/Documents/duplicity/bin/duplicity:124:9: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:125:14: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:126:9: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:131:9: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:132:14: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:133:9: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:160:11: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:161:11: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:162:11: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:168:11: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:169:11: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:170:11: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:895:20: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:907:20: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:908:20: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:1186:28: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:1189:28: W503 line break before binary operator
/home/mnjul/Documents/duplicity/bin/duplicity:1237:22: W503 line break before binary operator
 
 
======================================================================
FAIL: test_pylint (testing.test_code.CodeTest)
Pylint test (requires pylint to be installed to pass)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/mnjul/Documents/duplicity/testing/test_code.py", line 84, in test_pylint
    [0, 32])
  File "/home/mnjul/Documents/duplicity/testing/test_code.py", line 40, in run_checker
    self.assertTrue(process.returncode in returncodes, output)
AssertionError: ************* Module duplicity.backends.giobackend
E0712: 96: Catching an exception which doesn't inherit from BaseException: GError
E0712: 105: Catching an exception which doesn't inherit from BaseException: GError
 
 
----------------------------------------------------------------------



(end of test error msg)





2015-10-09 17:09 GMT-04:00 Aaron Whitehouse <address@hidden>:
Hi John,

Great to have another person keen to contribute!

To add to Kenneth's email, there isn't too much written guidance, but please make sure you've read README-REPO:
http://bazaar.launchpad.net/~duplicity-team/duplicity/0.7-series/view/head:/README-REPO
and please make sure all tests pass before you propose a merge.

Kind regards,

Aaron



On 09/10/15 22:06, Kenneth Loafman wrote:
Yes, file a bug report / enhancement request and tie the merge request to it.

Just propose the merge and it should happen fairly quickly.  I've already looked at the code (fairly simple) and have only one request.  Please update the man page as well so others will know about the additional option.


On Fri, Oct 9, 2015 at 11:16 AM, Min-Zhong "John" Lu / 呂敏中 <address@hidden> wrote:
Thanks Edgar! The new value turned out to be STANDARD_IA as documented in AWS [1].

I have made a small patch for duplicity commandline to accept the new storage class: http://bazaar.launchpad.net/~mnjul/duplicity/s3-infreq-access/revision/1131 and I'd like to contribute back into duplicity if that's at all possible.

As such, could anyone point me to guidelines/rules for contributing back to the official repository?
I'm looking for project-specific rules like:
1. If I should file a bug first and link my branch/commit message to that bug, and/or
2. If I should just propose a merge through launchpad, and if so, who shall I ask for review? Is there a predefined set of review types?

Much appreciated!
- John


2015-10-04 7:08 GMT-04:00 <address@hidden>:
On 03.10.2015 10:34, Min-Zhong "John" Lu / 呂敏中 wrote:
> Hi Duplicity folks,
>
> Amazon recently announced a new S3 storage class, Infrequent Access: https://aws.amazon.com/blogs/aws/aws-storage-update-new-lower-cost-s3-storage-option-glacier-price-reduction/ . Its storage price is lower than Reduced Redundancy but has a higher per-access price tag.
>
> I have enjoyed duplicity's support on storing volumes to S3 directly on Reduced Redundancy class ( --s3-use-rrs option). And for my own use cases, I believe IA is a more cost-effective option for me, so I'm wondering how I might let duplicity to directly store volumes to S3 on IA classes.
>
> Thus I'm wondering if support for new S3 storage classes will be planned for future duplicity versions. Also -- if it's at all possible -- is there any kind of quick hacks I can do to enable such support on my own machine? (I can re-build my version from source, for sure)
>

i guess that they introduced a new storage class value. see how it is done for rrs
 http://bazaar.launchpad.net/~duplicity-team/duplicity/0.7-series/view/head:/duplicity/backends/_boto_single.py#L222

..ede/duply.net

_______________________________________________
Duplicity-talk mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/duplicity-talk


_______________________________________________
Duplicity-talk mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/duplicity-talk




_______________________________________________
Duplicity-talk mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/duplicity-talk


_______________________________________________
Duplicity-talk mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/duplicity-talk



_______________________________________________
Duplicity-talk mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/duplicity-talk



_______________________________________________
Duplicity-talk mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/duplicity-talk


reply via email to
[Prev in Thread] Current Thread [Next in Thread]