emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master b9ac4f8.. (Fix locating pdump by symlink) breaks with stow


From: Ergus
Subject: Re: master b9ac4f8.. (Fix locating pdump by symlink) breaks with stow
Date: Mon, 24 Jun 2019 15:50:46 +0200
User-agent: NeoMutt/20180716

On Mon, Jun 24, 2019 at 06:21:12AM -0700, Daniel Colascione wrote:
On Mon, Jun 24, 2019 at 06:57:32PM +0700, Yuri Khan wrote:
On Mon, Jun 24, 2019 at 6:12 PM Ergus <address@hidden> wrote:

750|  char* argv0 = realpath (argv[0], NULL);
751|  if (!argv0)
752|    fatal ("could not resolve realpath of \"%s\": %s",
752|           argv0, strerror (errno));

This looks wrong. If we called realpath and it returned null, we???d
probably want the original argv[0] in the error message, not the null
result.


This also produces problems when using emacs from an alias like em o emc
which is a very common practice.

So there should be actually other conditions to try if the first
realpath call fails and not abort (call fatal) in the first try.

Try it now. Sorry about the botched change.


Hi Daniel:

Did you pushed any change too savannah/master?

Best Ergus



reply via email to

[Prev in Thread] Current Thread [Next in Thread]